You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/27 22:30:48 UTC
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1132: fix: click avatarDropdown setting, there will be a loading appeared
liuxiran opened a new pull request #1132:
URL: https://github.com/apache/apisix-dashboard/pull/1132
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
___
### Bugfix
- Description
[Test case]
1. click `settings` in avatarDropdown menu
1. a loading wiil appeared
- How to fix?
when click `settings`, there is a useless update `initialState`, just remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1132: fix: click avatarDropdown setting, there will be a loading appeared
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1132:
URL: https://github.com/apache/apisix-dashboard/pull/1132#issuecomment-751523636
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=h1) Report
> Merging [#1132](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=desc) (919c0e4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/14da383518a5942b8a027e8bbb306988aa5dcacc?el=desc) (14da383) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1132 +/- ##
==========================================
- Coverage 42.07% 42.02% -0.06%
==========================================
Files 30 30
Lines 1856 1856
==========================================
- Hits 781 780 -1
- Misses 965 966 +1
Partials 110 110
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1132/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.37% <0.00%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=footer). Last update [14da383...919c0e4](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1132: fix: click avatarDropdown setting, there will be a loading appeared
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1132:
URL: https://github.com/apache/apisix-dashboard/pull/1132#issuecomment-751523636
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=h1) Report
> Merging [#1132](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=desc) (75b8dc7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2f112ffcb4942a392c3a21acece5a712a5d5c1ab?el=desc) (2f112ff) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 42.30% 42.30%
=======================================
Files 31 31
Lines 1924 1924
=======================================
Hits 814 814
Misses 1000 1000
Partials 110 110
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=footer). Last update [2f112ff...75b8dc7](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1132: fix: click avatarDropdown setting, there will be a loading appeared
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1132:
URL: https://github.com/apache/apisix-dashboard/pull/1132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1132: fix: click avatarDropdown setting, there will be a loading appeared
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1132:
URL: https://github.com/apache/apisix-dashboard/pull/1132#issuecomment-751523636
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=h1) Report
> Merging [#1132](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=desc) (20e5b15) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/822aa6d1f40c5eb5bfef00030304eb5b619a9eea?el=desc) (822aa6d) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 42.30% 42.30%
=======================================
Files 31 31
Lines 1924 1924
=======================================
Hits 814 814
Misses 1000 1000
Partials 110 110
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=footer). Last update [822aa6d...20e5b15](https://codecov.io/gh/apache/apisix-dashboard/pull/1132?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org