[jira] [Commented] (CALCITE-1769) Push Filters down to druid when there a cast to numeric

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991478#comment-15991478 ] 

Julian Hyde commented on CALCITE-1769:
--------------------------------------

There have been 4 issues with CAST in the last month. That is exactly what a quality problem looks like. It's time to pro-actively write some tests. And it's time for me, as a reviewer, to ask hard questions when I get contributions.

Please don't call me "rude" and "unwelcoming" for doing my job.

As for formatting, how can you possibly claim that

{noformat}
  if (e.getOperands().get(0).isA(SqlKind.LITERAL)
      && (e.getType().getFamily() == SqlTypeFamily.TIMESTAMP || e.getType().getFamily()
        == SqlTypeFamily.NUMERIC)) {
{noformat}

is better than

{noformat}
  if (e.getOperands().get(0).isA(SqlKind.LITERAL)
      && (e.getType().getFamily() == SqlTypeFamily.TIMESTAMP
          || e.getType().getFamily() == SqlTypeFamily.NUMERIC)) {
{noformat}


> Push Filters down to druid when there a cast to numeric
> -------------------------------------------------------
>
>                 Key: CALCITE-1769
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1769
>             Project: Calcite
>          Issue Type: Bug
>          Components: druid
>            Reporter: slim bouguerra
>            Assignee: Julian Hyde
>             Fix For: 1.13.0
>
>
> Currently if we have cast to numeric over literal filter will not get pushed.
> For instance query like {code}SELECT page from druid_table_1 WHERE page < 5 group by page {code} from hive will introduce a cast over `5`.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)