You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2022/11/02 11:21:33 UTC
[commons-geometry] branch master updated: Update commons-numbers 1.0 to 1.1
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git
The following commit(s) were added to refs/heads/master by this push:
new 6de48f6d Update commons-numbers 1.0 to 1.1
6de48f6d is described below
commit 6de48f6df9d956500b0267a3c919b8c6d7cf0dbb
Author: aherbert <ah...@apache.org>
AuthorDate: Wed Nov 2 11:21:26 2022 +0000
Update commons-numbers 1.0 to 1.1
---
pom.xml | 26 ++++----------------------
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/pom.xml b/pom.xml
index aa38bd6a..5123ed97 100644
--- a/pom.xml
+++ b/pom.xml
@@ -89,7 +89,7 @@
<doclint.javadoc.qualifier></doclint.javadoc.qualifier>
<!-- Dependency versions -->
- <commons.numbers.version>1.0</commons.numbers.version>
+ <commons.numbers.version>1.1</commons.numbers.version>
<commons.rng.version>1.5</commons.rng.version>
<!-- Workaround to avoid the SVN site checkout in all modules.
@@ -138,28 +138,10 @@
<dependencies>
<dependency>
<groupId>org.apache.commons</groupId>
- <artifactId>commons-numbers-core</artifactId>
- <version>${commons.numbers.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-numbers-arrays</artifactId>
- <version>${commons.numbers.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-numbers-angle</artifactId>
- <version>${commons.numbers.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-numbers-fraction</artifactId>
- <version>${commons.numbers.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-numbers-quaternion</artifactId>
+ <artifactId>commons-numbers-bom</artifactId>
<version>${commons.numbers.version}</version>
+ <scope>import</scope>
+ <type>pom</type>
</dependency>
<dependency>
Re: [commons-geometry] branch master updated: Update commons-numbers 1.0 to 1.1
Posted by Alex Herbert <al...@gmail.com>.
On Wed, 2 Nov 2022 at 11:54, sebb <se...@gmail.com> wrote:
>
> On Wed, 2 Nov 2022 at 11:44, Alex Herbert <al...@gmail.com> wrote:
> >
> > On Wed, 2 Nov 2022 at 11:31, Gilles Sadowski <gi...@gmail.com> wrote:
> > >
> > > Hi Alex.
> > >
> > > Do I understand correctly that the change below may introduce dependencies
> > > on modules that are not actually used in the [Geometry] code?
> > >
> > > Regards,
> > > Gilles
> >
> > The git diff does not show that this change is in the
> > dependencyManagement section.
>
> Huh? AFAICT it *is* in the dependencyManagement section:
>
> https://github.com/apache/commons-geometry/blob/6de48f6df9d956500b0267a3c919b8c6d7cf0dbb/pom.xml#L143
To clarify my point: the plain text diff sent to the mailing list did
not show enough of the relevant section around the change to make it
clear it is in the dependencyManagement section. It starts with:
@@ -138,28 +138,10 @@
<dependencies>
<dependency>
So reading the diff you may think the change was in the dependencies section.
To see the correct location you have to look at the file to see the
surrounding tag for change location as:
<dependencyManagement>
<dependencies>
<dependency>
Alex
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [commons-geometry] branch master updated: Update commons-numbers 1.0 to 1.1
Posted by sebb <se...@gmail.com>.
On Wed, 2 Nov 2022 at 11:44, Alex Herbert <al...@gmail.com> wrote:
>
> On Wed, 2 Nov 2022 at 11:31, Gilles Sadowski <gi...@gmail.com> wrote:
> >
> > Hi Alex.
> >
> > Do I understand correctly that the change below may introduce dependencies
> > on modules that are not actually used in the [Geometry] code?
> >
> > Regards,
> > Gilles
>
> The git diff does not show that this change is in the
> dependencyManagement section.
Huh? AFAICT it *is* in the dependencyManagement section:
https://github.com/apache/commons-geometry/blob/6de48f6df9d956500b0267a3c919b8c6d7cf0dbb/pom.xml#L143
> So it does not bring in any
> dependencies. It specifies the version to bring in if a child pom adds
> a Numbers module. This ensures that all the versions brought in by any
> child pom that adds a numbers module is compatible.
>
> Alex
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [commons-geometry] branch master updated: Update commons-numbers 1.0 to 1.1
Posted by Alex Herbert <al...@gmail.com>.
On Wed, 2 Nov 2022 at 11:31, Gilles Sadowski <gi...@gmail.com> wrote:
>
> Hi Alex.
>
> Do I understand correctly that the change below may introduce dependencies
> on modules that are not actually used in the [Geometry] code?
>
> Regards,
> Gilles
The git diff does not show that this change is in the
dependencyManagement section. So it does not bring in any
dependencies. It specifies the version to bring in if a child pom adds
a Numbers module. This ensures that all the versions brought in by any
child pom that adds a numbers module is compatible.
Alex
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [commons-geometry] branch master updated: Update commons-numbers 1.0 to 1.1
Posted by Gilles Sadowski <gi...@gmail.com>.
Hi Alex.
Do I understand correctly that the change below may introduce dependencies
on modules that are not actually used in the [Geometry] code?
Regards,
Gilles
Le mer. 2 nov. 2022 à 12:21, <ah...@apache.org> a écrit :
>
> This is an automated email from the ASF dual-hosted git repository.
>
> aherbert pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-geometry.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 6de48f6d Update commons-numbers 1.0 to 1.1
> 6de48f6d is described below
>
> commit 6de48f6df9d956500b0267a3c919b8c6d7cf0dbb
> Author: aherbert <ah...@apache.org>
> AuthorDate: Wed Nov 2 11:21:26 2022 +0000
>
> Update commons-numbers 1.0 to 1.1
> ---
> pom.xml | 26 ++++----------------------
> 1 file changed, 4 insertions(+), 22 deletions(-)
>
> diff --git a/pom.xml b/pom.xml
> index aa38bd6a..5123ed97 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -89,7 +89,7 @@
> <doclint.javadoc.qualifier></doclint.javadoc.qualifier>
>
> <!-- Dependency versions -->
> - <commons.numbers.version>1.0</commons.numbers.version>
> + <commons.numbers.version>1.1</commons.numbers.version>
> <commons.rng.version>1.5</commons.rng.version>
>
> <!-- Workaround to avoid the SVN site checkout in all modules.
> @@ -138,28 +138,10 @@
> <dependencies>
> <dependency>
> <groupId>org.apache.commons</groupId>
> - <artifactId>commons-numbers-core</artifactId>
> - <version>${commons.numbers.version}</version>
> - </dependency>
> - <dependency>
> - <groupId>org.apache.commons</groupId>
> - <artifactId>commons-numbers-arrays</artifactId>
> - <version>${commons.numbers.version}</version>
> - </dependency>
> - <dependency>
> - <groupId>org.apache.commons</groupId>
> - <artifactId>commons-numbers-angle</artifactId>
> - <version>${commons.numbers.version}</version>
> - </dependency>
> - <dependency>
> - <groupId>org.apache.commons</groupId>
> - <artifactId>commons-numbers-fraction</artifactId>
> - <version>${commons.numbers.version}</version>
> - </dependency>
> - <dependency>
> - <groupId>org.apache.commons</groupId>
> - <artifactId>commons-numbers-quaternion</artifactId>
> + <artifactId>commons-numbers-bom</artifactId>
> <version>${commons.numbers.version}</version>
> + <scope>import</scope>
> + <type>pom</type>
> </dependency>
>
> <dependency>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org