You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Michael Greene (JIRA)" <ji...@apache.org> on 2009/05/09 09:03:46 UTC

[jira] Created: (THRIFT-494) Python library should identify with correct version, license, website

Python library should identify with correct version, license, website
---------------------------------------------------------------------

                 Key: THRIFT-494
                 URL: https://issues.apache.org/jira/browse/THRIFT-494
             Project: Thrift
          Issue Type: Bug
          Components: Library (Python)
    Affects Versions: 0.1
            Reporter: Michael Greene
            Priority: Trivial


The Python library currently identifies with distutils as a distribution called "Thrift" with version 1.0, with the old Facebook website, and no distutils mention of license.  This should be fixed before release, particularly the versioning as future upgrade paths will be smoother with a proper version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-494) Python library should identify with correct version, license, website

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated THRIFT-494:
----------------------------------

    Patch Info: [Patch Available]

> Python library should identify with correct version, license, website
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-494
>                 URL: https://issues.apache.org/jira/browse/THRIFT-494
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>    Affects Versions: 0.1
>            Reporter: Michael Greene
>            Priority: Trivial
>         Attachments: THRIFT-494-001.diff
>
>
> The Python library currently identifies with distutils as a distribution called "Thrift" with version 1.0, with the old Facebook website, and no distutils mention of license.  This should be fixed before release, particularly the versioning as future upgrade paths will be smoother with a proper version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-494) Python library should identify with correct version, license, website

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707744#action_12707744 ] 

David Reiss commented on THRIFT-494:
------------------------------------

Sounds good.  Maybe we should update the author and author email too.  Maybe "Thrift Developers" and "thrift-dev@incubator.apache.org"?  Also, what would you think about having it read the version from configure.ac so we don't have duplication of that information?

> Python library should identify with correct version, license, website
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-494
>                 URL: https://issues.apache.org/jira/browse/THRIFT-494
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>    Affects Versions: 0.1
>            Reporter: Michael Greene
>            Priority: Trivial
>         Attachments: THRIFT-494-001.diff
>
>
> The Python library currently identifies with distutils as a distribution called "Thrift" with version 1.0, with the old Facebook website, and no distutils mention of license.  This should be fixed before release, particularly the versioning as future upgrade paths will be smoother with a proper version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-494) Python library should identify with correct version, license, website

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707745#action_12707745 ] 

Michael Greene commented on THRIFT-494:
---------------------------------------

The author/author e-mail changes sound good.

I could go either way on the configure change.  I wouldn't mind having configure.ac somehow set the version, but it would make it more difficult to grab just the python library and build it with a proper version.

It would be nice if both
{{svn co http://svn.apache.org/repos/asf/incubator/thrift/trunk/lib/py pythrift && cd pythrift && python setup.py install}}
and
{{easy_install -U Thrift}}
installed properly.



> Python library should identify with correct version, license, website
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-494
>                 URL: https://issues.apache.org/jira/browse/THRIFT-494
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>    Affects Versions: 0.1
>            Reporter: Michael Greene
>            Priority: Trivial
>         Attachments: THRIFT-494-001.diff
>
>
> The Python library currently identifies with distutils as a distribution called "Thrift" with version 1.0, with the old Facebook website, and no distutils mention of license.  This should be fixed before release, particularly the versioning as future upgrade paths will be smoother with a proper version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-494) Python library should identify with correct version, license, website

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated THRIFT-494:
----------------------------------

    Attachment: THRIFT-494-001.diff

The attached patch corrects these three issues.

> Python library should identify with correct version, license, website
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-494
>                 URL: https://issues.apache.org/jira/browse/THRIFT-494
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>    Affects Versions: 0.1
>            Reporter: Michael Greene
>            Priority: Trivial
>         Attachments: THRIFT-494-001.diff
>
>
> The Python library currently identifies with distutils as a distribution called "Thrift" with version 1.0, with the old Facebook website, and no distutils mention of license.  This should be fixed before release, particularly the versioning as future upgrade paths will be smoother with a proper version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-494) Python library should identify with correct version, license, website

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-494.
--------------------------------

    Resolution: Fixed
      Assignee: Michael Greene

> Python library should identify with correct version, license, website
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-494
>                 URL: https://issues.apache.org/jira/browse/THRIFT-494
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (Python)
>    Affects Versions: 0.1
>            Reporter: Michael Greene
>            Assignee: Michael Greene
>            Priority: Trivial
>         Attachments: THRIFT-494-001.diff
>
>
> The Python library currently identifies with distutils as a distribution called "Thrift" with version 1.0, with the old Facebook website, and no distutils mention of license.  This should be fixed before release, particularly the versioning as future upgrade paths will be smoother with a proper version.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.