[GitHub] lprashant-94 commented on issue #4728: [sql_lab]Disabled run query button if sql query editor is empty

[GitBox <gi...@apache.org>]

lprashant-94 commented on issue #4728: [sql_lab]Disabled run query button if sql query editor is empty
URL: https://github.com/apache/incubator-superset/pull/4728#issuecomment-378127111
 
 
   I didn't understand your comment, can you please elaborate.
   
   On Tue 3 Apr, 2018, 10:13 AM Maxime Beauchemin, <no...@github.com>
   wrote:
   
   > *@mistercrunch* requested changes on this pull request.
   > ------------------------------
   >
   > In superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
   > <https://github.com/apache/incubator-superset/pull/4728#discussion_r178712748>
   > :
   >
   > > @@ -43,6 +44,7 @@ export default function RunQueryActionButton(props) {
   >        onClick={() => props.runQuery(true)}
   >        key="run-async-btn"
   >        tooltip={t('Run query asynchronously')}
   > +      disabled={!props.sql.trim()}
   >
   > I'm confused as to why the linter isn't asking for sql to be in propTypes.
   > I wanted to make sure it's entered as a string and can never be null
   > through a defaultProps = ''
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-superset/pull/4728#pullrequestreview-108814357>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AWLeFKQiCQRRzNVaFtppGyPqfk1C2fpmks5tkv31gaJpZM4TCy38>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services