You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/26 19:49:00 UTC

[jira] [Commented] (NIFI-5761) ReplaceText processor can stop processing data if it evaluates invalid expressions

    [ https://issues.apache.org/jira/browse/NIFI-5761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665616#comment-16665616 ] 

ASF GitHub Bot commented on NIFI-5761:
--------------------------------------

GitHub user gardellajuanpablo opened a pull request:

    https://github.com/apache/nifi/pull/3112

    NIFI-5761 ReplaceText processor can stop processing data if it evalua…

    …tes invalid expressions
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gardellajuanpablo/nifi NIFI-5761

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3112
    
----
commit f26389e1f7f429f8fdc7f84938ff5b39658e1af1
Author: Gardella Juan Pablo <ga...@...>
Date:   2018-10-26T19:41:26Z

    NIFI-5761 ReplaceText processor can stop processing data if it evaluates invalid expressions

----


> ReplaceText processor can stop processing data if it evaluates invalid expressions
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-5761
>                 URL: https://issues.apache.org/jira/browse/NIFI-5761
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.5.0, 1.7.1
>         Environment: ALL
>            Reporter: Gardella Juan Pablo
>            Priority: Major
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Given a flowfile body with nifi expression, when _ReplaceText_ processor evaluates it and the expression throws an exception, the processor will rollback the flowfile and keep trying to evaluate instead of send the flowfile to _failure_ relationshipt.
> Discussion Thread: http://apache-nifi-users-list.2361937.n4.nabble.com/ReplaceText-cannot-consume-messages-if-Regex-does-not-match-td5986.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)