You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by sansanichfb <gi...@git.apache.org> on 2017/10/09 23:53:46 UTC
[GitHub] incubator-hawq pull request #1300: HAWQ-1538. Install internal profiles defi...
GitHub user sansanichfb opened a pull request:
https://github.com/apache/incubator-hawq/pull/1300
HAWQ-1538. Install internal profiles definition file in conf directory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sansanichfb/incubator-hawq HAWQ-1538
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1300
----
commit 2d36e1044ec715f790ce79c3db1e2881c8349bdc
Author: Oleksandr Diachenko <od...@pivotal.io>
Date: 2017-10-09T23:53:12Z
HAWQ-1538. Install internal profiles definition file in conf directory.
----
---
[GitHub] incubator-hawq issue #1300: HAWQ-1538. Install internal profiles definition ...
Posted by lavjain <gi...@git.apache.org>.
Github user lavjain commented on the issue:
https://github.com/apache/incubator-hawq/pull/1300
If the fix is working please feel free to merge. It is hard to review this kind of change.
---
[GitHub] incubator-hawq issue #1300: HAWQ-1538. Install internal profiles definition ...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on the issue:
https://github.com/apache/incubator-hawq/pull/1300
@lavjain feel free to try it out by ```make install/tar/bundle DATABASE=gpdb```
---
[GitHub] incubator-hawq pull request #1300: HAWQ-1538. Install internal profiles defi...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1300
---
[GitHub] incubator-hawq pull request #1300: HAWQ-1538. Install internal profiles defi...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1300#discussion_r143605483
--- Diff: pxf/build.gradle ---
@@ -310,7 +309,7 @@ project('pxf-service') {
}
project.distTar {
- from('src/main/resources/pxf-profiles-default.xml') { into 'conf' rename { 'pxf-profiles.xml' } }
--- End diff --
Sure, we have them, here is layout:
{code}
office-5-181:gpdb adiachenko$ ls -alh pxf/conf
total 96
drwxr-xr-x 12 adiachenko admin 408B Oct 9 17:07 .
drwxr-xr-x 8 adiachenko admin 272B Oct 9 17:07 ..
-rw-r--r-- 1 adiachenko admin 1.3K Oct 9 17:07 pxf-env.sh
-rw-r--r-- 1 adiachenko admin 1.3K Oct 9 17:07 pxf-log4j.properties
-rw-r--r-- 1 adiachenko admin 3.1K Oct 9 17:07 pxf-private.classpath
-rw-r--r-- 1 adiachenko admin 2.7K Oct 9 17:07 pxf-privatebigtop.classpath
-rw-r--r-- 1 adiachenko admin 3.4K Oct 9 17:07 pxf-privatehdp.classpath
-rw-r--r-- 1 adiachenko admin 3.4K Oct 9 17:07 pxf-privatephd.classpath
-rw-r--r-- 1 adiachenko admin 9.3K Oct 9 17:07 pxf-profiles-default.xml
-rw-r--r-- 1 adiachenko admin 1.1K Oct 9 17:07 pxf-profiles.xml
-rw-r--r-- 1 adiachenko admin 1.2K Oct 9 17:07 pxf-public.classpath
-rw-r--r-- 1 adiachenko admin 1.3K Oct 9 17:07 pxf-site.xml
{code}
---
[GitHub] incubator-hawq pull request #1300: HAWQ-1538. Install internal profiles defi...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1300#discussion_r143605252
--- Diff: pxf/build.gradle ---
@@ -310,7 +309,7 @@ project('pxf-service') {
}
project.distTar {
- from('src/main/resources/pxf-profiles-default.xml') { into 'conf' rename { 'pxf-profiles.xml' } }
--- End diff --
We might need both pxf-profile-default and pxf-profile in the tar
---
[GitHub] incubator-hawq pull request #1300: HAWQ-1538. Install internal profiles defi...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1300#discussion_r143605611
--- Diff: pxf/build.gradle ---
@@ -310,7 +309,7 @@ project('pxf-service') {
}
project.distTar {
- from('src/main/resources/pxf-profiles-default.xml') { into 'conf' rename { 'pxf-profiles.xml' } }
--- End diff --
Cool, as long as the above files exist with the right content we should be good
---