You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/10/24 01:15:05 UTC

Review Request 27115: Discard label/tag when parsing Version string.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27115/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Bugs: MESOS-1975
    https://issues.apache.org/jira/browse/MESOS-1975


Repository: mesos-git


Description
-------

Any string after the first "-" is discarded to allow and the parsing continues on the remaining string.  This allows for the tags/labels to be discarded.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 53b14e21b409f40f5c6cb7271c3c82f98b120f95 
  3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp 9f5343150148c03aa16a0ec6623f9b5446a872b6 

Diff: https://reviews.apache.org/r/27115/diff/


Testing
-------

Added some tests to version_tests and ran make check.


Thanks,

Kapil Arya

Re: Review Request 27115: Discard label/tag when parsing Version string.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27115/#review58184
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Oct. 23, 2014, 11:15 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27115/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 11:15 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1975
>     https://issues.apache.org/jira/browse/MESOS-1975
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Any string after the first "-" is discarded to allow and the parsing continues on the remaining string.  This allows for the tags/labels to be discarded.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 53b14e21b409f40f5c6cb7271c3c82f98b120f95 
>   3rdparty/libprocess/3rdparty/stout/tests/version_tests.cpp 9f5343150148c03aa16a0ec6623f9b5446a872b6 
> 
> Diff: https://reviews.apache.org/r/27115/diff/
> 
> 
> Testing
> -------
> 
> Added some tests to version_tests and ran make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>