[GitHub] [incubator-iceberg] rdblue commented on issue #675: Inherit snapshot ids for manifest entries

[GitBox <gi...@apache.org>]

rdblue commented on issue #675: Inherit snapshot ids for manifest entries
URL: https://github.com/apache/incubator-iceberg/pull/675#issuecomment-573819724
 
 
   @aokolnychyi, the implementation looks correct to me. My only remaining concern is our forward-compatibility guarantee that older readers will continue to be able to read tables written by future versions within the format version in metadata.
   
   Technically, this breaks that guarantee for tables that are appended to using manifests. I think that means we should test that older readers can read tables written with this that don't have appended manifests (I think Avro will throw a runtime error if it encounters a null snapshot ID, but will allow attempting to read). We should also probably add a feature flag to turn on this breaking behavior -- that way you can opt into using manifest files without a snapshot ID, knowing that it will break older readers. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org