You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Abhishek Jain <aj...@binghamton.edu> on 2017/02/10 01:12:11 UTC
Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
Diff: https://reviews.apache.org/r/56523/diff/
Testing
-------
Tests:
------
aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
Completed Task status information:
-----------------------------------
3 minutes ago - KILLED : Instructed to kill task.
02/09 19:52:53 LOCAL \u2022 PENDING
02/09 19:52:53 LOCAL \u2022 ASSIGNED
02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
Build tests:
-------------
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Abhishek Jain
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165134
-----------------------------------------------------------
This looks very useful. Thanks!
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java (line 131)
<https://reviews.apache.org/r/56523/#comment236946>
How about leaving the `:` out? It seems a little but unnecessary to me.
src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java (line 83)
<https://reviews.apache.org/r/56523/#comment236947>
Indentation is off - here and in some other places below. I am wondering how this came past our checkstyle rules :-)
- Stephan Erb
On Feb. 10, 2017, 2:12 a.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 2:12 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165274
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On Feb. 10, 2017, 8:24 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 8:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165387
-----------------------------------------------------------
This is now on master.
- Zameer Manji
On Feb. 13, 2017, 12:09 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 12:09 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Bugs: AURORA-1806
> https://issues.apache.org/jira/browse/AURORA-1806
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165385
-----------------------------------------------------------
Ship it!
LGTM, thanks for your contribution.
- Zameer Manji
On Feb. 13, 2017, 12:09 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 12:09 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Bugs: AURORA-1806
> https://issues.apache.org/jira/browse/AURORA-1806
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Abhishek Jain <aj...@binghamton.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/
-----------------------------------------------------------
(Updated Feb. 13, 2017, 12:09 p.m.)
Review request for Aurora, Stephan Erb and Zameer Manji.
Bugs: AURORA-1806
https://issues.apache.org/jira/browse/AURORA-1806
Repository: aurora
Description
-------
Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
Diff: https://reviews.apache.org/r/56523/diff/
Testing
-------
Tests:
------
aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
Completed Task status information:
-----------------------------------
3 minutes ago - KILLED : Instructed to kill task.
02/09 19:52:53 LOCAL \u2022 PENDING
02/09 19:52:53 LOCAL \u2022 ASSIGNED
02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
Build tests:
-------------
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Abhishek Jain
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Abhishek Jain <aj...@binghamton.edu>.
> On Feb. 10, 2017, 7:36 p.m., Aurora ReviewBot wrote:
> > Master (ad3377a) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > Test coverage missing for org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule
> > Test coverage missing for org/apache/aurora/scheduler/reconciliation/TaskTimeout
> > Test coverage missing for org/apache/aurora/scheduler/reconciliation/TaskTimeout$TimedOutTaskHandler
> > Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob$CronBatchWorker
> > Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$TaskGroupBatchWorker
> > Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$1
> > Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups
> > Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$2
> > Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$1
> > Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$3
> > Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$2
> > Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$1
> > Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats
> > Test coverage missing for org/apache/aurora/scheduler/thrift/AuditMessages
> > Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor
> > Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$1
> > Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$2
> > Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$3
> > Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptorModule$PreemptorService
> > Test coverage missing for org/apache/aurora/scheduler/events/WebhookModule
> > Test coverage missing for org/apache/aurora/scheduler/events/Webhook
> > Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
> > Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
> > Test coverage missing for org/apache/aurora/scheduler/TaskVars
> > Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
> > Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
> > Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
> > Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> > ==============================================================================
> >
> > BUILD FAILED
> >
> > Total time: 5 mins 1.673 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
@ReviewBot retry
- Abhishek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165152
-----------------------------------------------------------
On Feb. 10, 2017, 7:24 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 7:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165152
-----------------------------------------------------------
Master (ad3377a) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule
Test coverage missing for org/apache/aurora/scheduler/reconciliation/TaskTimeout
Test coverage missing for org/apache/aurora/scheduler/reconciliation/TaskTimeout$TimedOutTaskHandler
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob$CronBatchWorker
Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$TaskGroupBatchWorker
Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$1
Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$2
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$1
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$3
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$2
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$1
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats
Test coverage missing for org/apache/aurora/scheduler/thrift/AuditMessages
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$1
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$2
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$3
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptorModule$PreemptorService
Test coverage missing for org/apache/aurora/scheduler/events/WebhookModule
Test coverage missing for org/apache/aurora/scheduler/events/Webhook
Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
Test coverage missing for org/apache/aurora/scheduler/TaskVars
Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 5 mins 1.673 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 10, 2017, 7:24 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 7:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165280
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Feb. 10, 2017, 8:24 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 8:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Abhishek Jain <aj...@binghamton.edu>.
> On Feb. 12, 2017, 9:16 p.m., Aurora ReviewBot wrote:
> > Master (ad3377a) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > Test coverage missing for org/apache/aurora/scheduler/base/AsyncUtil$2
> > Test coverage missing for org/apache/aurora/Protobufs
> > Test coverage missing for org/apache/aurora/scheduler/filter/AttributeFilter
> > Test coverage missing for org/apache/aurora/scheduler/filter/ConstraintMatcher
> > Test coverage missing for org/apache/aurora/scheduler/filter/SchedulingFilterImpl$1
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken
> > Test coverage missing for org/apache/aurora/scheduler/resources/AcceptedOffer
> > Test coverage missing for org/apache/aurora/scheduler/resources/ResourceMapper$PortMapper
> > Test coverage missing for org/apache/aurora/scheduler/state/TaskAssigner$TaskAssignerImpl
> > Test coverage missing for org/apache/aurora/scheduler/state/UUIDGenerator$UUIDGeneratorImpl
> > Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor
> > Test coverage missing for org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler
> > Test coverage missing for org/apache/aurora/scheduler/http/api/ApiBeta
> > Test coverage missing for org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler$1
> > Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob
> > Test coverage missing for org/apache/aurora/scheduler/offers/OfferManager$OfferManagerImpl$HostOffers$1
> > Test coverage missing for org/apache/aurora/scheduler/offers/OfferSettings
> > Test coverage missing for org/apache/aurora/scheduler/mesos/MesosTaskFactory$MesosTaskFactoryImpl
> > Test coverage missing for org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule
> > Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor$1
> > Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor$2
> > Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor
> > Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftWorkload$ThriftWorkloadCounterImpl
> > Test coverage missing for org/apache/aurora/scheduler/preemptor/BiCache$1
> > Test coverage missing for org/apache/aurora/scheduler/events/NotifyingSchedulingFilter
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
> > Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
> > Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
> > Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> > ==============================================================================
> >
> > BUILD FAILED
> >
> > Total time: 5 mins 36.461 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
@ReviewBot retry
- Abhishek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165275
-----------------------------------------------------------
On Feb. 10, 2017, 7:24 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 7:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Stephan Erb <se...@apache.org>.
> On Feb. 12, 2017, 10:16 p.m., Aurora ReviewBot wrote:
> > Master (ad3377a) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > Test coverage missing for org/apache/aurora/scheduler/base/AsyncUtil$2
> > Test coverage missing for org/apache/aurora/Protobufs
> > Test coverage missing for org/apache/aurora/scheduler/filter/AttributeFilter
> > Test coverage missing for org/apache/aurora/scheduler/filter/ConstraintMatcher
> > Test coverage missing for org/apache/aurora/scheduler/filter/SchedulingFilterImpl$1
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken
> > Test coverage missing for org/apache/aurora/scheduler/resources/AcceptedOffer
> > Test coverage missing for org/apache/aurora/scheduler/resources/ResourceMapper$PortMapper
> > Test coverage missing for org/apache/aurora/scheduler/state/TaskAssigner$TaskAssignerImpl
> > Test coverage missing for org/apache/aurora/scheduler/state/UUIDGenerator$UUIDGeneratorImpl
> > Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor
> > Test coverage missing for org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler
> > Test coverage missing for org/apache/aurora/scheduler/http/api/ApiBeta
> > Test coverage missing for org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler$1
> > Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob
> > Test coverage missing for org/apache/aurora/scheduler/offers/OfferManager$OfferManagerImpl$HostOffers$1
> > Test coverage missing for org/apache/aurora/scheduler/offers/OfferSettings
> > Test coverage missing for org/apache/aurora/scheduler/mesos/MesosTaskFactory$MesosTaskFactoryImpl
> > Test coverage missing for org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule
> > Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor$1
> > Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor$2
> > Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor
> > Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftWorkload$ThriftWorkloadCounterImpl
> > Test coverage missing for org/apache/aurora/scheduler/preemptor/BiCache$1
> > Test coverage missing for org/apache/aurora/scheduler/events/NotifyingSchedulingFilter
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
> > Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
> > Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
> > Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
> > Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> > ==============================================================================
> >
> > BUILD FAILED
> >
> > Total time: 5 mins 36.461 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
>
> Abhishek Jain wrote:
> @ReviewBot retry
I believe this is a Jenkins problem. One more try...
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165275
-----------------------------------------------------------
On Feb. 10, 2017, 8:24 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 8:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165275
-----------------------------------------------------------
Master (ad3377a) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/base/AsyncUtil$2
Test coverage missing for org/apache/aurora/Protobufs
Test coverage missing for org/apache/aurora/scheduler/filter/AttributeFilter
Test coverage missing for org/apache/aurora/scheduler/filter/ConstraintMatcher
Test coverage missing for org/apache/aurora/scheduler/filter/SchedulingFilterImpl$1
Test coverage missing for org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken
Test coverage missing for org/apache/aurora/scheduler/resources/AcceptedOffer
Test coverage missing for org/apache/aurora/scheduler/resources/ResourceMapper$PortMapper
Test coverage missing for org/apache/aurora/scheduler/state/TaskAssigner$TaskAssignerImpl
Test coverage missing for org/apache/aurora/scheduler/state/UUIDGenerator$UUIDGeneratorImpl
Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor
Test coverage missing for org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler
Test coverage missing for org/apache/aurora/scheduler/http/api/ApiBeta
Test coverage missing for org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler$1
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob
Test coverage missing for org/apache/aurora/scheduler/offers/OfferManager$OfferManagerImpl$HostOffers$1
Test coverage missing for org/apache/aurora/scheduler/offers/OfferSettings
Test coverage missing for org/apache/aurora/scheduler/mesos/MesosTaskFactory$MesosTaskFactoryImpl
Test coverage missing for org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor$1
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor$2
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor
Test coverage missing for org/apache/aurora/scheduler/thrift/aop/ThriftWorkload$ThriftWorkloadCounterImpl
Test coverage missing for org/apache/aurora/scheduler/preemptor/BiCache$1
Test coverage missing for org/apache/aurora/scheduler/events/NotifyingSchedulingFilter
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 5 mins 36.461 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 10, 2017, 7:24 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 7:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165281
-----------------------------------------------------------
Ship it!
Master (ad3377a) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 10, 2017, 7:24 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 7:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165279
-----------------------------------------------------------
@ReviewBot retry
- Stephan Erb
On Feb. 10, 2017, 8:24 p.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 8:24 p.m.)
>
>
> Review request for Aurora, Stephan Erb and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Abhishek Jain <aj...@binghamton.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 7:24 p.m.)
Review request for Aurora, Stephan Erb and Zameer Manji.
Changes
-------
Fixed indentation and removed the unnecessary ':' from the 'Killed for job update..' message.
Repository: aurora
Description
-------
Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
Diff: https://reviews.apache.org/r/56523/diff/
Testing
-------
Tests:
------
aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
Completed Task status information:
-----------------------------------
3 minutes ago - KILLED : Instructed to kill task.
02/09 19:52:53 LOCAL \u2022 PENDING
02/09 19:52:53 LOCAL \u2022 ASSIGNED
02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
Build tests:
-------------
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Abhishek Jain
Re: Review Request 56523: Displaying update id after 'Killed for job
update'
message for the update that resulted in the task getting killed
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165047
-----------------------------------------------------------
Ship it!
Master (ad3377a) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 10, 2017, 1:12 a.m., Abhishek Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 1:12 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd
> src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6
> src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776
>
> Diff: https://reviews.apache.org/r/56523/diff/
>
>
> Testing
> -------
>
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
>
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL \u2022 PENDING
> 02/09 19:52:53 LOCAL \u2022 ASSIGNED
> 02/09 19:52:54 LOCAL \u2022 STARTING \u2022 Initializing sandbox.
> 02/09 19:52:55 LOCAL \u2022 RUNNING \u2022 No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL \u2022 KILLING \u2022 Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL \u2022 KILLED \u2022 Instructed to kill task.
>
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Abhishek Jain
>
>