You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by ff...@apache.org on 2012/09/03 08:17:40 UTC

svn commit: r1380133 - in /cxf/branches/2.6.x-fixes: ./ rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java

Author: ffang
Date: Mon Sep  3 06:17:40 2012
New Revision: 1380133

URL: http://svn.apache.org/viewvc?rev=1380133&view=rev
Log:
Merged revisions 1380132 via svnmerge from 
https://svn.apache.org/repos/asf/cxf/trunk

........
  r1380132 | ffang | 2012-09-03 14:14:14 +0800 (δΈ€, 03  9 2012) | 1 line
  
  [CXF-4493]add NPE guard when FaultAction is used with OneWay
........

Modified:
    cxf/branches/2.6.x-fixes/   (props changed)
    cxf/branches/2.6.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java

Propchange: cxf/branches/2.6.x-fixes/
------------------------------------------------------------------------------
  Merged /cxf/trunk:r1380132

Propchange: cxf/branches/2.6.x-fixes/
------------------------------------------------------------------------------
Binary property 'svnmerge-integrated' - no diff available.

Modified: cxf/branches/2.6.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.6.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java?rev=1380133&r1=1380132&r2=1380133&view=diff
==============================================================================
--- cxf/branches/2.6.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java (original)
+++ cxf/branches/2.6.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/support/JaxWsServiceFactoryBean.java Mon Sep  3 06:17:40 2012
@@ -579,7 +579,7 @@ public class JaxWsServiceFactoryBean ext
             if (faultActions != null && faultActions.length > 0 && operation.getFaults() != null) {
                 for (FaultAction faultAction : faultActions) {
                     FaultInfo faultInfo = getFaultInfo(operation, faultAction.className());
-                    if (!StringUtils.isEmpty(faultAction.value())) {
+                    if (faultInfo != null && !StringUtils.isEmpty(faultAction.value())) {
                         faultInfo.addExtensionAttribute(JAXWSAConstants.WSAW_ACTION_QNAME, faultAction
                             .value());
                         faultInfo.addExtensionAttribute(JAXWSAConstants.WSAM_ACTION_QNAME, faultAction
@@ -587,7 +587,7 @@ public class JaxWsServiceFactoryBean ext
                     }
                     if (operation.isUnwrappedCapable()) {
                         faultInfo = getFaultInfo(operation.getUnwrappedOperation(), faultAction.className());
-                        if (!StringUtils.isEmpty(faultAction.value())) {
+                        if (faultInfo != null && !StringUtils.isEmpty(faultAction.value())) {
                             faultInfo.addExtensionAttribute(JAXWSAConstants.WSAW_ACTION_QNAME, faultAction
                                 .value());
                             faultInfo.addExtensionAttribute(JAXWSAConstants.WSAM_ACTION_QNAME, faultAction