You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2017/12/12 21:35:10 UTC

[GitHub] joshgrob commented on a change in pull request #697: BMA2XX Sensor

joshgrob commented on a change in pull request #697: BMA2XX Sensor
URL: https://github.com/apache/mynewt-core/pull/697#discussion_r156501999
 
 

 ##########
 File path: hw/bsp/bmd300eval/src/hal_bsp.c
 ##########
 @@ -74,6 +75,14 @@ static const struct nrf52_hal_spi_cfg os_bsp_spi0s_cfg = {
 };
 #endif
 
+#if MYNEWT_VAL(I2C_0)
+static const struct nrf52_hal_i2c_cfg hal_i2c_cfg = {
+    .scl_pin = 15,
 
 Review comment:
   Thank you for the comments Rymanluk.  I will make sure to add the topic prefix to commits.  There are three differences from studying the datasheets:
   1.  Chip Id Value from register 0x00
   2. G scale values as you mentioned above
   3. Bandwidth settings.  On BMA280 there is no 1000hz option (just 500 and ODR max which is unfiltered 2000hz).
   
   About hal_bsp.c - I agree that using mynewt_vals for I2C pins would make it consistent.  Will do make the change. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services