[GitHub] [hudi] danny0405 commented on a diff in pull request #9309: [HUDI-6605] write handlers not close in find way in ClientIds and DirectWriteMarkers

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #9309:
URL: https://github.com/apache/hudi/pull/9309#discussion_r1278283081


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/marker/DirectWriteMarkers.java:
##########
@@ -189,13 +190,12 @@ private Option<Path> create(Path markerPath, boolean checkIfExists) {
     } catch (IOException e) {
       throw new HoodieIOException("Failed to make dir " + dirPath, e);
     }
-    try {
+    try (FSDataOutputStream fsDataOutputStream = fs.create(markerPath, false)) {
       if (checkIfExists && fs.exists(markerPath)) {
         LOG.warn("Marker Path=" + markerPath + " already exists, cancel creation");

Review Comment:
   The logic is not equivalent with before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org