[GitHub] [hive] pvary commented on a change in pull request #2813: HIVE-25736: Close ORC readers

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2813:
URL: https://github.com/apache/hive/pull/2813#discussion_r756651986



##########
File path: ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestNewInputOutputFormat.java
##########
@@ -225,7 +225,8 @@ public void testNewOutputFormat() throws Exception {
     
     assertEquals(intWritable.get(), firstIntValue);
     assertEquals(text.toString(), firstStringValue);

Review comment:
       This is test only code. If we would like to do this correctly, then we should use try-with-resources block for every reader. That would mean serious refactor of the affected classes. Which would mean manual backporting every change affecting those.
   If you still feel that we should do it, I am happy to do the change. I wanted to keep the change small and manageable.
   
   Thanks, Peter 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org