You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by alaunay <gi...@git.apache.org> on 2017/04/22 15:27:29 UTC
[GitHub] bigtop pull request #198: Small fixes for bigtop 1.2.0
GitHub user alaunay opened a pull request:
https://github.com/apache/bigtop/pull/198
Small fixes for bigtop 1.2.0
Those small fixes allow for compilation using a fresh Debian distro/user, without prior downloaded files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alaunay/bigtop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #198
----
commit 255e38c2ff937a3856122b95379edb667005b875
Author: Arnaud Launay <as...@launay.org>
Date: 2017-04-22T15:23:24Z
AMBARI-20686: Add ID to allow compilation with recent maven
commit 1619b043668e218b1fde785465e19dc171fa2272
Author: Arnaud Launay <as...@launay.org>
Date: 2017-04-22T15:24:34Z
Storm 1.1.0-SNAPSHOT is no longer available, use released version
commit c14d72ebb5f789150e7c0d7310db0f0d552d0d52
Author: Arnaud Launay <as...@launay.org>
Date: 2017-04-22T15:26:02Z
According to BIGTOP-2730, we use Zookeeper 3.4.10
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #198: Small fixes for bigtop 1.2.0
Posted by alaunay <gi...@git.apache.org>.
Github user alaunay commented on the issue:
https://github.com/apache/bigtop/pull/198
this one went sideways :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] bigtop pull request #198: Small fixes for bigtop 1.2.0
Posted by Evans Ye <ev...@apache.org>.
Oh, I see Olaf already made you a patch in BIGTOP-2751, and is working on
BIGTOP-2729, so I think you can focus on the other 3 commits.
2017-04-23 17:27 GMT+08:00 Evans Ye <ev...@apache.org>:
> Hi Arnaud,
>
> Typically to submit a patch I'll create a branch and apply a fix on it.
> Then create a PR against bigtop master with [BIGTOP-XXXX] JIRA TITLE
> attached as PR's title.
>
> I see you've cleanly separated each issue into a commit, but it squashed
> into one PR. So the things left to do here:
>
> * Create 5 JIRAs, each for the different issue to fix
> * git checkout -b BIGTOP-XXXX to create 5 branches
> * Cherry-pick your commit into those branches
> * git commit --amend to change the commit message to [BIGTOP-XXXX] JIRA
> TITLE
> * Push those 5 branches to your forked bigtop git repo
> * Create 5 PRs (git will auto-grap the git commit message as PR title)
> * DONE
>
> I'm not quite sure what you knows and what you don't know. So please feel
> free to ask so that we can help. :)
>
> Thanks.
>
> Evans Ye
>
>
>
>
>
> 2017-04-22 23:51 GMT+08:00 Arnaud Launay <as...@launay.org>:
>
>> Le Sat, Apr 22, 2017 at 03:27:29PM +0000, alaunay a écrit:
>> > GitHub user alaunay opened a pull request:
>> > https://github.com/apache/bigtop/pull/198
>>
>> This went sideways... I thought I could create multiple pull
>> requests, but the patches I added after that pull were
>> automatically added, and are /not/ to be committed (especially
>> the Solr stuff).
>>
>> Should I like undo everything and create branch for each stuff ?
>> I've no idea how that works. I find it finally far easier to
>> send patches attached to mails :-)
>>
>> Arnaud.
>>
>
>
Re: [GitHub] bigtop pull request #198: Small fixes for bigtop 1.2.0
Posted by Evans Ye <ev...@apache.org>.
Hi Arnaud,
Typically to submit a patch I'll create a branch and apply a fix on it.
Then create a PR against bigtop master with [BIGTOP-XXXX] JIRA TITLE
attached as PR's title.
I see you've cleanly separated each issue into a commit, but it squashed
into one PR. So the things left to do here:
* Create 5 JIRAs, each for the different issue to fix
* git checkout -b BIGTOP-XXXX to create 5 branches
* Cherry-pick your commit into those branches
* git commit --amend to change the commit message to [BIGTOP-XXXX] JIRA
TITLE
* Push those 5 branches to your forked bigtop git repo
* Create 5 PRs (git will auto-grap the git commit message as PR title)
* DONE
I'm not quite sure what you knows and what you don't know. So please feel
free to ask so that we can help. :)
Thanks.
Evans Ye
2017-04-22 23:51 GMT+08:00 Arnaud Launay <as...@launay.org>:
> Le Sat, Apr 22, 2017 at 03:27:29PM +0000, alaunay a écrit:
> > GitHub user alaunay opened a pull request:
> > https://github.com/apache/bigtop/pull/198
>
> This went sideways... I thought I could create multiple pull
> requests, but the patches I added after that pull were
> automatically added, and are /not/ to be committed (especially
> the Solr stuff).
>
> Should I like undo everything and create branch for each stuff ?
> I've no idea how that works. I find it finally far easier to
> send patches attached to mails :-)
>
> Arnaud.
>
Re: [GitHub] bigtop pull request #198: Small fixes for bigtop 1.2.0
Posted by Arnaud Launay <as...@launay.org>.
Le Sat, Apr 22, 2017 at 03:27:29PM +0000, alaunay a écrit:
> GitHub user alaunay opened a pull request:
> https://github.com/apache/bigtop/pull/198
This went sideways... I thought I could create multiple pull
requests, but the patches I added after that pull were
automatically added, and are /not/ to be committed (especially
the Solr stuff).
Should I like undo everything and create branch for each stuff ?
I've no idea how that works. I find it finally far easier to
send patches attached to mails :-)
Arnaud.
[GitHub] bigtop pull request #198: Small fixes for bigtop 1.2.0
Posted by alaunay <gi...@git.apache.org>.
Github user alaunay closed the pull request at:
https://github.com/apache/bigtop/pull/198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---