[jira] Commented: (FOR-1165) Samples Tab does not stay highlighted when sub-tab or sub-tab menu items are chosen - Pelt Theme

["Thorsten Scherler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FOR-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913952#action_12913952 ] 

Thorsten Scherler commented on FOR-1165:
----------------------------------------

Revision: 999870 fixed this issue.
Log:
Fixing blanks and line breaks which caused a js exception

The problem are line breaks in the xsl:
-              <xsl:attribute name="onclick">SwitchMenu(' 
-              <xsl:value-of select="normalize-space($tagid)" />')</xsl:attribute>
+              <!-- it is very important to not have a line break here since it will break the resulting code -->
+              <xsl:attribute name="onclick">SwitchMenu('<xsl:value-of select="normalize-space($tagid)" />')</xsl:attribute>
   
I fixed a similar problem in Revision: 999887. I am not sure but it seems that the code cleaning apps (which do the formating) are to be blamed for that. I wonder if it makes sense to exclude xsl in that processing since they are very likely to break with lb on the wrong point of the code.

> Samples Tab does not stay highlighted when sub-tab or sub-tab menu items are chosen - Pelt Theme
> ------------------------------------------------------------------------------------------------
>
>                 Key: FOR-1165
>                 URL: https://issues.apache.org/jira/browse/FOR-1165
>             Project: Forrest
>          Issue Type: Bug
>          Components: Plugin: internal.dispatcher
>    Affects Versions: 0.9-dev
>            Reporter: Gavin
>             Fix For: 0.9-dev
>
>
> Choose the 'Samples' tab and it correctly highlights.
> Then choose either 'Samples1' or 'Samples2' sub-tab and the 'Samples' highlight is removed. Correct behaviour as per Pelt Skin is for the highlighting color to remain.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.