[GitHub] rdhabalia commented on a change in pull request #566: Fix test : avoid multiple registration of zkClient-aspect in test

[gi...@git.apache.org]

rdhabalia commented on a change in pull request #566: Fix test : avoid multiple registration of zkClient-aspect in test
URL: https://github.com/apache/incubator-pulsar/pull/566#discussion_r127328991
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/zookeeper/ZooKeeperClientAspectJTest.java
 ##########
 @@ -73,7 +73,9 @@
     
     static {
         // load agent with aspectjweaver-Agent for testing
-        AgentLoader.loadAgentClass(Agent.class.getName(), null);
+        // maven-test waves advice on build-goal so, maven doesn't need explicit loading
+        // uncomment it while testing on eclipse: 
+        //AgentLoader.loadAgentClass(Agent.class.getName(), null);
 
 Review comment:
   I couldn't find a way to find out that advice is already registered. I will fix it, once figure out the way.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services