You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/08/30 20:30:39 UTC

[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #8790: Fix an error on SSL config reload (plus some cleanup).

cmcfarlen commented on code in PR #8790:
URL: https://github.com/apache/trafficserver/pull/8790#discussion_r958902310


##########
src/traffic_server/InkAPI.cc:
##########
@@ -1873,6 +1887,122 @@ _TSfree(void *ptr)
   ats_free(ptr);
 }
 
+// Support code for TSHeapBuf.
+namespace
+{
+class HeapBuf

Review Comment:
   I meant that effectively, HeapBuf could be written as `using HeapBuf = std::unique_ptr<std::string>` and TSHeapBuf would be (opaquely) `*std::string`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org