You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/11/28 05:44:07 UTC
[kudu-CR] [consensus queue] definitive
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8663
Change subject: [consensus_queue] definitive
......................................................................
[consensus_queue] definitive
Report the health status of a replica as HEALTHY only if the
last recent exchage status was Status::OK. Except for a few
other definitive cases where it's clear that the replica has failed,
report the health of the replica is reported as UNKNOWN.
The rationalte behind is simple:
* The HEALTHY replicas are the ones which can replicate Raft
transactions from the leader replica with no issues.
* The FAILED replicas are the ones which will definitely fail
to replicate Raft transactions from the leader replica.
* The rest is goes into the UNKNOWN basket, which covers the cases
when there hasn't been a single attempt to contact the replica yet,
there was a transient error during the last communication with the
replica, etc.
Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 17 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8663/1
--
To view, visit http://gerrit.cloudera.org:8080/8663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Gerrit-Change-Number: 8663
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [consensus queue] update replica health reporting
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8663 )
Change subject: [consensus_queue] update replica health reporting
......................................................................
Patch Set 2:
> Build Failed
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/10985/ : FAILURE
It seems some updates are needed.
--
To view, visit http://gerrit.cloudera.org:8080/8663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Gerrit-Change-Number: 8663
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 06:29:33 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus queue] update replica health reporting
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8663
to look at the new patch set (#4).
Change subject: [consensus_queue] update replica health reporting
......................................................................
[consensus_queue] update replica health reporting
Report the health status of a replica as HEALTHY only if the
last recent exchage status was Status::OK. Except for a few
other definitive cases where it's clear that the replica has failed,
the health of the replica is reported as UNKNOWN.
The rationalte behind is simple:
* The HEALTHY replicas are the ones which can replicate Raft
transactions from the leader replica with no issues.
* The FAILED replicas are the ones which will definitely fail
to replicate Raft transactions.
* The rest is goes into the UNKNOWN bucket, which covers the cases
when there hasn't been a single attempt to contact the replica yet,
there was a transient error during the last communication with the
replica, etc.
Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 17 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8663/4
--
To view, visit http://gerrit.cloudera.org:8080/8663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Gerrit-Change-Number: 8663
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus queue] update replica health reporting
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8663
to look at the new patch set (#2).
Change subject: [consensus_queue] update replica health reporting
......................................................................
[consensus_queue] update replica health reporting
Report the health status of a replica as HEALTHY only if the
last recent exchage status was Status::OK. Except for a few
other definitive cases where it's clear that the replica has failed,
report the health of the replica is reported as UNKNOWN.
The rationalte behind is simple:
* The HEALTHY replicas are the ones which can replicate Raft
transactions from the leader replica with no issues.
* The FAILED replicas are the ones which will definitely fail
to replicate Raft transactions from the leader replica.
* The rest is goes into the UNKNOWN basket, which covers the cases
when there hasn't been a single attempt to contact the replica yet,
there was a transient error during the last communication with the
replica, etc.
Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 17 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8663/2
--
To view, visit http://gerrit.cloudera.org:8080/8663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Gerrit-Change-Number: 8663
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus queue] update replica health reporting
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8663 )
Change subject: [consensus_queue] update replica health reporting
......................................................................
[consensus_queue] update replica health reporting
Report the health status of a replica as HEALTHY only if the
last recent exchage status was Status::OK. Except for a few
other definitive cases where it's clear that the replica has failed,
the health of the replica is reported as UNKNOWN.
The rationalte behind is simple:
* The HEALTHY replicas are the ones which can replicate Raft
transactions from the leader replica with no issues.
* The FAILED replicas are the ones which will definitely fail
to replicate Raft transactions.
* The rest is goes into the UNKNOWN bucket, which covers the cases
when there hasn't been a single attempt to contact the replica yet,
there was a transient error during the last communication with the
replica, etc.
Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Reviewed-on: http://gerrit.cloudera.org:8080/8663
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 17 insertions(+), 15 deletions(-)
Approvals:
Alexey Serbin: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Gerrit-Change-Number: 8663
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus queue] update replica health reporting
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8663 )
Change subject: [consensus_queue] update replica health reporting
......................................................................
Patch Set 4: Verified+1
The flake in RaftConsensusNonVoterITest.CatalogManagerAddsNonVoter is fixed in the follow-up patch: https://gerrit.cloudera.org/#/c/8664/
--
To view, visit http://gerrit.cloudera.org:8080/8663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Gerrit-Change-Number: 8663
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 21:08:02 +0000
Gerrit-HasComments: No
[kudu-CR] WIP [consensus queue] update replica health reporting
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8663
to look at the new patch set (#3).
Change subject: WIP [consensus_queue] update replica health reporting
......................................................................
WIP [consensus_queue] update replica health reporting
Report the health status of a replica as HEALTHY only if the
last recent exchage status was Status::OK. Except for a few
other definitive cases where it's clear that the replica has failed,
report the health of the replica is reported as UNKNOWN.
The rationalte behind is simple:
* The HEALTHY replicas are the ones which can replicate Raft
transactions from the leader replica with no issues.
* The FAILED replicas are the ones which will definitely fail
to replicate Raft transactions from the leader replica.
* The rest is goes into the UNKNOWN basket, which covers the cases
when there hasn't been a single attempt to contact the replica yet,
there was a transient error during the last communication with the
replica, etc.
WIP: need to update the code, some tests are failing
Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 17 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/8663/3
--
To view, visit http://gerrit.cloudera.org:8080/8663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Gerrit-Change-Number: 8663
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus queue] update replica health reporting
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8663 )
Change subject: [consensus_queue] update replica health reporting
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Gerrit-Change-Number: 8663
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [consensus queue] update replica health reporting
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8663 )
Change subject: [consensus_queue] update replica health reporting
......................................................................
Patch Set 4: Code-Review+2
This make sense.
--
To view, visit http://gerrit.cloudera.org:8080/8663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99da4352da0b0d1846c92eb2abac7197a58bfd62
Gerrit-Change-Number: 8663
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 21:10:12 +0000
Gerrit-HasComments: No