You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2018/09/22 13:40:10 UTC

[commons-geometry] 09/10: GEOMETRY-17: fixing checkstyle issues

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git

commit 39076770b2b6630dc8e713c06831bce2116339ba
Author: Matt Juntunen <ma...@hotmail.com>
AuthorDate: Fri Sep 21 23:26:42 2018 -0400

    GEOMETRY-17: fixing checkstyle issues
---
 .../geometry/euclidean/MultiDimensionalEuclideanVector.java   | 11 +++++------
 .../apache/commons/geometry/euclidean/threed/Vector3D.java    |  2 +-
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/MultiDimensionalEuclideanVector.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/MultiDimensionalEuclideanVector.java
index 5c916e4..6553a53 100644
--- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/MultiDimensionalEuclideanVector.java
+++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/MultiDimensionalEuclideanVector.java
@@ -16,7 +16,6 @@
  */
 package org.apache.commons.geometry.euclidean;
 
-import org.apache.commons.geometry.core.Vector;
 import org.apache.commons.geometry.core.exception.IllegalNormException;
 
 /**
@@ -38,7 +37,7 @@ public interface MultiDimensionalEuclideanVector<P extends EuclideanPoint<P, V>,
      * @param base base vector
      * @return the vector projection of the instance onto {@code base}
      * @exception IllegalNormException if the norm of the base vector is zero, NaN, or infinite
-     * @see #reject(Vector)
+     * @see #reject(MultiDimensionalEuclideanVector)
      */
     V project(V base);
 
@@ -53,7 +52,7 @@ public interface MultiDimensionalEuclideanVector<P extends EuclideanPoint<P, V>,
      * @param base base vector
      * @return the vector rejection of the instance from {@code base}
      * @exception IllegalNormException if the norm of the base vector is zero, NaN, or infinite
-     * @see #project(Vector)
+     * @see #project(MultiDimensionalEuclideanVector)
      */
     V reject(V base);
 
@@ -62,7 +61,7 @@ public interface MultiDimensionalEuclideanVector<P extends EuclideanPoint<P, V>,
      * @throws IllegalNormException if the norm of the current instance is zero, NaN,
      *  or infinite
      */
-    public V orthogonal();
+    V orthogonal();
 
     /** Get a unit vector orthogonal to the current vector and pointing in the direction
      * of {@code dir}. This method is equivalent to calling {@code dir.reject(vec).normalize()}
@@ -73,5 +72,5 @@ public interface MultiDimensionalEuclideanVector<P extends EuclideanPoint<P, V>,
      * @throws IllegalNormException if either vector norm is zero, NaN or infinite,
      *      or the given vector is collinear with this vector.
      */
-    public V orthogonal(V dir);
-}
\ No newline at end of file
+    V orthogonal(V dir);
+}
diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
index 0436efe..c075ff2 100644
--- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
+++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Vector3D.java
@@ -290,7 +290,7 @@ public class Vector3D extends Cartesian3D implements MultiDimensionalEuclideanVe
      *   Vector3D k = u.normalize();
      *   Vector3D i = k.orthogonal();
      *   Vector3D j = k.crossProduct(i);
-     * </code></pre></p>
+     * </code></pre>
      * @return a unit vector orthogonal to the instance
      * @throws IllegalNormException if the norm of the instance is zero, NaN,
      *  or infinite