You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/03 00:12:41 UTC

[GitHub] [spark] mbaldini commented on pull request #32040: Add @ExpressionDescription to TimeWindow to generate missing documentation

mbaldini commented on pull request #32040:
URL: https://github.com/apache/spark/pull/32040#issuecomment-812761741


   Ah I see. Where would be the correct location? I'd be happy to update it.On Apr 2, 2021 4:56 PM, Takeshi Yamamuro ***@***.***> wrote:
   @maropu commented on this pull request.
   
   
   
   In sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TimeWindow.scala:
   > +    Examples:
   +      > SELECT _FUNC_(timestamp('2020-04-25 15:49:11.914'), '5 minutes');
   +       2020-04-25 15:45:00, 2020-04-25 15:50:00
   +
   +      > SELECT _FUNC_(timestamp('2020-04-25 15:49:11.914'), '5 minutes', '2 minutes');
   +       2020-04-25 15:45:00, 2020-04-25 15:50:00
   +       2020-04-25 15:47:00, 2020-04-25 15:52:00
   +       2020-04-25 15:49:00, 2020-04-25 15:54:00
   +
   +      > SELECT _FUNC_(timestamp('2020-04-25 15:49:11.914'), '5 minutes', '2 minutes', '30 seconds');
   +       2020-04-25 15:44:30, 2020-04-25 15:49:30
   +       2020-04-25 15:46:30, 2020-04-25 15:51:30
   +       2020-04-25 15:48:30, 2020-04-25 15:53:30
   +  """,
   +  group = "datetime_funcs",
   +  since = "2.0.0")
   
   This is not a unevaluable SQL expr, so we don't put ExpressionDescription here.
   
   —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org