You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2025/12/16 06:22:10 UTC

[PR] Minor cleanups removing SDK references from Core [airflow]

uranusjr opened a new pull request, #59491:
URL: https://github.com/apache/airflow/pull/59491

   Some obvious ones we can simply remove without any consequences.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor cleanups removing SDK references from Core [airflow]

Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #59491:
URL: https://github.com/apache/airflow/pull/59491#discussion_r2623532133


##########
airflow-core/src/airflow/api_fastapi/core_api/services/ui/task_group.py:
##########
@@ -57,7 +56,7 @@ def task_group_to_dict(task_item_or_group, parent_group_is_mapped=False):
             node_operator["is_mapped"] = True
         return node_operator
 
-    task_group: TaskGroup = task_item_or_group
+    task_group = task_item_or_group

Review Comment:
   Should we instead put in under type check block and import `SerializedTaskGroup`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor cleanups removing SDK references from Core [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #59491:
URL: https://github.com/apache/airflow/pull/59491#discussion_r2625475580


##########
airflow-core/src/airflow/api_fastapi/core_api/services/ui/task_group.py:
##########
@@ -57,7 +56,7 @@ def task_group_to_dict(task_item_or_group, parent_group_is_mapped=False):
             node_operator["is_mapped"] = True
         return node_operator
 
-    task_group: TaskGroup = task_item_or_group
+    task_group = task_item_or_group

Review Comment:
   #59194 will allow better type hints here (this one should only take serialized types). Annotating it here before that would result in a linter error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor cleanups removing SDK references from Core [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #59491:
URL: https://github.com/apache/airflow/pull/59491#discussion_r2625475580


##########
airflow-core/src/airflow/api_fastapi/core_api/services/ui/task_group.py:
##########
@@ -57,7 +56,7 @@ def task_group_to_dict(task_item_or_group, parent_group_is_mapped=False):
             node_operator["is_mapped"] = True
         return node_operator
 
-    task_group: TaskGroup = task_item_or_group
+    task_group = task_item_or_group

Review Comment:
   #59194 will allow better type hints here (this one should only take serialized types).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Minor cleanups removing SDK references from Core [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr merged PR #59491:
URL: https://github.com/apache/airflow/pull/59491


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org