[GitHub] [flink] tillrohrmann commented on a change in pull request #13258: [FLINK-18899][yarn] Enrich the description of 'yarn.application-attempts'

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #13258:
URL: https://github.com/apache/flink/pull/13258#discussion_r478550796



##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##########
@@ -82,9 +82,9 @@
 	public static final ConfigOption<String> APPLICATION_ATTEMPTS =
 		key("yarn.application-attempts")
 		.noDefaultValue()
-		.withDescription("Number of ApplicationMaster restarts. Note that that the entire Flink cluster will restart" +
-			" and the YARN Client will loose the connection. Also, the JobManager address will change and you’ll need" +
-			" to set the JM host:port manually. It is recommended to leave this option at 1.");
+		.withDescription("Number of ApplicationMaster restarts. By default, the value will be set to 1 in the non high availability case" +
+			" and 2 in the high availability case. The restart number is also limited by YARN (configured via 'yarn.resourcemanager.am.max-attempts')." +
+			" Note that that the entire Flink cluster will restart and the YARN Client will loose the connection.");

Review comment:
       ```suggestion
   			" Note that that the entire Flink cluster will restart and the YARN Client will lose the connection.");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org