You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Stamatis Zampetakis <za...@gmail.com> on 2021/06/02 10:13:35 UTC
Minified javascript in source releases
Hi all,
In the recent votes for Calcite [1] and Avatica [2] there were some -1
votes regarding minified javascript files present in the source releases.
The concerns are raised for the following files:
site/js/html5shiv.min.js
site/js/respond.min.js
From discussions in other lists it seems that there are Apache source
releases including minified files so I don't think we are violating any
policy by including them but there are deferring opinions on this topic
[3,4].
To avoid bringing back the discussion to if minified javascript should be
present or not I would like to propose one of the following alternatives:
1. It seems that both of the aforementioned scripts [5,6] are used for
compatibility reasons with old browsers. I think most of the people are not
using these browsers anymore so I would suggest removing them altogether
from the code.
2. If for some reason we need to keep them then we could directly use the
non minified version. The difference of minified vs unminified for both
files is ~6KB so I doubt it will have any real impact with the internet
connections that we use nowadays.
What do you think?
Best,
Stamatis
[1]
https://lists.apache.org/thread.html/r049cf5b953eb5824ba37df21094dd7c1e92146d659db4735ad121593%40%3Cdev.calcite.apache.org%3E
[2]
https://lists.apache.org/thread.html/r074720fc062bde09a7e69dc77f77754c7fd4c22f1357514f6b2196d0%40%3Cdev.calcite.apache.org%3E
[3]
https://lists.apache.org/thread.html/rcddc30dd1f0c7f20709e09de7202d4d6885d6235a7fce1c1ab46e4ed%40%3Clegal-discuss.apache.org%3E
[4]
http://mail-archives.apache.org/mod_mbox/incubator-general/201805.mbox/%3c89A47C0B-E74E-4571-B282-DBE505291539@classsoftware.com%3e
[5] https://github.com/scottjehl/Respond
[6] https://github.com/aFarkas/html5shiv
Re: Minified javascript in source releases
Posted by Stamatis Zampetakis <za...@gmail.com>.
Thank you all for the feedback.
I committed the change for Calcite [1] and Avatica [2]. I checked locally
and things seemed to work fine.
I published the Calcite website with the changes today so if you notice any
problems please let me know.
Best,
Stamatis
[1]
https://github.com/apache/calcite/commit/7f5e9b8b7e6b4afd8e4f21524aa3c4ce8b7ddb61
[2]
https://github.com/apache/calcite-avatica/commit/e4f22c33c5a67257056ee4428486b900cc139038
On Thu, Jun 3, 2021 at 12:20 AM Francis Chuang <fr...@apache.org>
wrote:
> +1 for removing those 2 scripts. They are for compatibility with very
> old browsers that have been discontinued for many years, so it makes
> sense to reduce the bloat.
>
> Francis
>
> On 3/06/2021 5:25 am, Julian Hyde wrote:
> > +0 to remove them entirely, if that is possible.
> >
> > -1 to keep in git but remove from source releases. We are already in
> > compliance with Apache policy, best I can tell.
> >
> >
> > On Wed, Jun 2, 2021 at 12:08 PM Haisheng Yuan <hy...@apache.org> wrote:
> >>
> >> +1 for removing them entirely.
> >>
> >> Thanks,
> >> Haisheng Yuan
> >>
> >> On 2021/06/02 13:36:05, Alessandro Solimando <
> alessandro.solimando@gmail.com> wrote:
> >>> Hi all,
> >>> +1 for removing them as well, all the mentioned sw versions in [5,6]
> >>> are extremely, extremely old.
> >>>
> >>> Best regards,
> >>> Alessandro
> >>>
> >>> On Wed, 2 Jun 2021 at 14:38, Michael Mior <mm...@apache.org> wrote:
> >>>>
> >>>> +1 for removing these entirely. I don't believe they are currently
> necessary.
> >>>> --
> >>>> Michael Mior
> >>>> mmior@apache.org
> >>>>
> >>>> Le mer. 2 juin 2021 à 06:13, Stamatis Zampetakis <za...@gmail.com>
> a écrit :
> >>>>>
> >>>>> Hi all,
> >>>>>
> >>>>> In the recent votes for Calcite [1] and Avatica [2] there were some
> -1
> >>>>> votes regarding minified javascript files present in the source
> releases.
> >>>>>
> >>>>> The concerns are raised for the following files:
> >>>>> site/js/html5shiv.min.js
> >>>>> site/js/respond.min.js
> >>>>>
> >>>>> From discussions in other lists it seems that there are Apache
> source
> >>>>> releases including minified files so I don't think we are violating
> any
> >>>>> policy by including them but there are deferring opinions on this
> topic
> >>>>> [3,4].
> >>>>>
> >>>>> To avoid bringing back the discussion to if minified javascript
> should be
> >>>>> present or not I would like to propose one of the following
> alternatives:
> >>>>>
> >>>>> 1. It seems that both of the aforementioned scripts [5,6] are used
> for
> >>>>> compatibility reasons with old browsers. I think most of the people
> are not
> >>>>> using these browsers anymore so I would suggest removing them
> altogether
> >>>>> from the code.
> >>>>>
> >>>>> 2. If for some reason we need to keep them then we could directly
> use the
> >>>>> non minified version. The difference of minified vs unminified for
> both
> >>>>> files is ~6KB so I doubt it will have any real impact with the
> internet
> >>>>> connections that we use nowadays.
> >>>>>
> >>>>> What do you think?
> >>>>>
> >>>>> Best,
> >>>>> Stamatis
> >>>>>
> >>>>> [1]
> >>>>>
> https://lists.apache.org/thread.html/r049cf5b953eb5824ba37df21094dd7c1e92146d659db4735ad121593%40%3Cdev.calcite.apache.org%3E
> >>>>> [2]
> >>>>>
> https://lists.apache.org/thread.html/r074720fc062bde09a7e69dc77f77754c7fd4c22f1357514f6b2196d0%40%3Cdev.calcite.apache.org%3E
> >>>>> [3]
> >>>>>
> https://lists.apache.org/thread.html/rcddc30dd1f0c7f20709e09de7202d4d6885d6235a7fce1c1ab46e4ed%40%3Clegal-discuss.apache.org%3E
> >>>>> [4]
> >>>>>
> http://mail-archives.apache.org/mod_mbox/incubator-general/201805.mbox/%3c89A47C0B-E74E-4571-B282-DBE505291539@classsoftware.com%3e
> >>>>> [5] https://github.com/scottjehl/Respond
> >>>>> [6] https://github.com/aFarkas/html5shiv
> >>>
>
Re: Minified javascript in source releases
Posted by Francis Chuang <fr...@apache.org>.
+1 for removing those 2 scripts. They are for compatibility with very
old browsers that have been discontinued for many years, so it makes
sense to reduce the bloat.
Francis
On 3/06/2021 5:25 am, Julian Hyde wrote:
> +0 to remove them entirely, if that is possible.
>
> -1 to keep in git but remove from source releases. We are already in
> compliance with Apache policy, best I can tell.
>
>
> On Wed, Jun 2, 2021 at 12:08 PM Haisheng Yuan <hy...@apache.org> wrote:
>>
>> +1 for removing them entirely.
>>
>> Thanks,
>> Haisheng Yuan
>>
>> On 2021/06/02 13:36:05, Alessandro Solimando <al...@gmail.com> wrote:
>>> Hi all,
>>> +1 for removing them as well, all the mentioned sw versions in [5,6]
>>> are extremely, extremely old.
>>>
>>> Best regards,
>>> Alessandro
>>>
>>> On Wed, 2 Jun 2021 at 14:38, Michael Mior <mm...@apache.org> wrote:
>>>>
>>>> +1 for removing these entirely. I don't believe they are currently necessary.
>>>> --
>>>> Michael Mior
>>>> mmior@apache.org
>>>>
>>>> Le mer. 2 juin 2021 à 06:13, Stamatis Zampetakis <za...@gmail.com> a écrit :
>>>>>
>>>>> Hi all,
>>>>>
>>>>> In the recent votes for Calcite [1] and Avatica [2] there were some -1
>>>>> votes regarding minified javascript files present in the source releases.
>>>>>
>>>>> The concerns are raised for the following files:
>>>>> site/js/html5shiv.min.js
>>>>> site/js/respond.min.js
>>>>>
>>>>> From discussions in other lists it seems that there are Apache source
>>>>> releases including minified files so I don't think we are violating any
>>>>> policy by including them but there are deferring opinions on this topic
>>>>> [3,4].
>>>>>
>>>>> To avoid bringing back the discussion to if minified javascript should be
>>>>> present or not I would like to propose one of the following alternatives:
>>>>>
>>>>> 1. It seems that both of the aforementioned scripts [5,6] are used for
>>>>> compatibility reasons with old browsers. I think most of the people are not
>>>>> using these browsers anymore so I would suggest removing them altogether
>>>>> from the code.
>>>>>
>>>>> 2. If for some reason we need to keep them then we could directly use the
>>>>> non minified version. The difference of minified vs unminified for both
>>>>> files is ~6KB so I doubt it will have any real impact with the internet
>>>>> connections that we use nowadays.
>>>>>
>>>>> What do you think?
>>>>>
>>>>> Best,
>>>>> Stamatis
>>>>>
>>>>> [1]
>>>>> https://lists.apache.org/thread.html/r049cf5b953eb5824ba37df21094dd7c1e92146d659db4735ad121593%40%3Cdev.calcite.apache.org%3E
>>>>> [2]
>>>>> https://lists.apache.org/thread.html/r074720fc062bde09a7e69dc77f77754c7fd4c22f1357514f6b2196d0%40%3Cdev.calcite.apache.org%3E
>>>>> [3]
>>>>> https://lists.apache.org/thread.html/rcddc30dd1f0c7f20709e09de7202d4d6885d6235a7fce1c1ab46e4ed%40%3Clegal-discuss.apache.org%3E
>>>>> [4]
>>>>> http://mail-archives.apache.org/mod_mbox/incubator-general/201805.mbox/%3c89A47C0B-E74E-4571-B282-DBE505291539@classsoftware.com%3e
>>>>> [5] https://github.com/scottjehl/Respond
>>>>> [6] https://github.com/aFarkas/html5shiv
>>>
Re: Minified javascript in source releases
Posted by Julian Hyde <jh...@apache.org>.
+0 to remove them entirely, if that is possible.
-1 to keep in git but remove from source releases. We are already in
compliance with Apache policy, best I can tell.
On Wed, Jun 2, 2021 at 12:08 PM Haisheng Yuan <hy...@apache.org> wrote:
>
> +1 for removing them entirely.
>
> Thanks,
> Haisheng Yuan
>
> On 2021/06/02 13:36:05, Alessandro Solimando <al...@gmail.com> wrote:
> > Hi all,
> > +1 for removing them as well, all the mentioned sw versions in [5,6]
> > are extremely, extremely old.
> >
> > Best regards,
> > Alessandro
> >
> > On Wed, 2 Jun 2021 at 14:38, Michael Mior <mm...@apache.org> wrote:
> > >
> > > +1 for removing these entirely. I don't believe they are currently necessary.
> > > --
> > > Michael Mior
> > > mmior@apache.org
> > >
> > > Le mer. 2 juin 2021 à 06:13, Stamatis Zampetakis <za...@gmail.com> a écrit :
> > > >
> > > > Hi all,
> > > >
> > > > In the recent votes for Calcite [1] and Avatica [2] there were some -1
> > > > votes regarding minified javascript files present in the source releases.
> > > >
> > > > The concerns are raised for the following files:
> > > > site/js/html5shiv.min.js
> > > > site/js/respond.min.js
> > > >
> > > > From discussions in other lists it seems that there are Apache source
> > > > releases including minified files so I don't think we are violating any
> > > > policy by including them but there are deferring opinions on this topic
> > > > [3,4].
> > > >
> > > > To avoid bringing back the discussion to if minified javascript should be
> > > > present or not I would like to propose one of the following alternatives:
> > > >
> > > > 1. It seems that both of the aforementioned scripts [5,6] are used for
> > > > compatibility reasons with old browsers. I think most of the people are not
> > > > using these browsers anymore so I would suggest removing them altogether
> > > > from the code.
> > > >
> > > > 2. If for some reason we need to keep them then we could directly use the
> > > > non minified version. The difference of minified vs unminified for both
> > > > files is ~6KB so I doubt it will have any real impact with the internet
> > > > connections that we use nowadays.
> > > >
> > > > What do you think?
> > > >
> > > > Best,
> > > > Stamatis
> > > >
> > > > [1]
> > > > https://lists.apache.org/thread.html/r049cf5b953eb5824ba37df21094dd7c1e92146d659db4735ad121593%40%3Cdev.calcite.apache.org%3E
> > > > [2]
> > > > https://lists.apache.org/thread.html/r074720fc062bde09a7e69dc77f77754c7fd4c22f1357514f6b2196d0%40%3Cdev.calcite.apache.org%3E
> > > > [3]
> > > > https://lists.apache.org/thread.html/rcddc30dd1f0c7f20709e09de7202d4d6885d6235a7fce1c1ab46e4ed%40%3Clegal-discuss.apache.org%3E
> > > > [4]
> > > > http://mail-archives.apache.org/mod_mbox/incubator-general/201805.mbox/%3c89A47C0B-E74E-4571-B282-DBE505291539@classsoftware.com%3e
> > > > [5] https://github.com/scottjehl/Respond
> > > > [6] https://github.com/aFarkas/html5shiv
> >
Re: Minified javascript in source releases
Posted by Haisheng Yuan <hy...@apache.org>.
+1 for removing them entirely.
Thanks,
Haisheng Yuan
On 2021/06/02 13:36:05, Alessandro Solimando <al...@gmail.com> wrote:
> Hi all,
> +1 for removing them as well, all the mentioned sw versions in [5,6]
> are extremely, extremely old.
>
> Best regards,
> Alessandro
>
> On Wed, 2 Jun 2021 at 14:38, Michael Mior <mm...@apache.org> wrote:
> >
> > +1 for removing these entirely. I don't believe they are currently necessary.
> > --
> > Michael Mior
> > mmior@apache.org
> >
> > Le mer. 2 juin 2021 à 06:13, Stamatis Zampetakis <za...@gmail.com> a écrit :
> > >
> > > Hi all,
> > >
> > > In the recent votes for Calcite [1] and Avatica [2] there were some -1
> > > votes regarding minified javascript files present in the source releases.
> > >
> > > The concerns are raised for the following files:
> > > site/js/html5shiv.min.js
> > > site/js/respond.min.js
> > >
> > > From discussions in other lists it seems that there are Apache source
> > > releases including minified files so I don't think we are violating any
> > > policy by including them but there are deferring opinions on this topic
> > > [3,4].
> > >
> > > To avoid bringing back the discussion to if minified javascript should be
> > > present or not I would like to propose one of the following alternatives:
> > >
> > > 1. It seems that both of the aforementioned scripts [5,6] are used for
> > > compatibility reasons with old browsers. I think most of the people are not
> > > using these browsers anymore so I would suggest removing them altogether
> > > from the code.
> > >
> > > 2. If for some reason we need to keep them then we could directly use the
> > > non minified version. The difference of minified vs unminified for both
> > > files is ~6KB so I doubt it will have any real impact with the internet
> > > connections that we use nowadays.
> > >
> > > What do you think?
> > >
> > > Best,
> > > Stamatis
> > >
> > > [1]
> > > https://lists.apache.org/thread.html/r049cf5b953eb5824ba37df21094dd7c1e92146d659db4735ad121593%40%3Cdev.calcite.apache.org%3E
> > > [2]
> > > https://lists.apache.org/thread.html/r074720fc062bde09a7e69dc77f77754c7fd4c22f1357514f6b2196d0%40%3Cdev.calcite.apache.org%3E
> > > [3]
> > > https://lists.apache.org/thread.html/rcddc30dd1f0c7f20709e09de7202d4d6885d6235a7fce1c1ab46e4ed%40%3Clegal-discuss.apache.org%3E
> > > [4]
> > > http://mail-archives.apache.org/mod_mbox/incubator-general/201805.mbox/%3c89A47C0B-E74E-4571-B282-DBE505291539@classsoftware.com%3e
> > > [5] https://github.com/scottjehl/Respond
> > > [6] https://github.com/aFarkas/html5shiv
>
Re: Minified javascript in source releases
Posted by Alessandro Solimando <al...@gmail.com>.
Hi all,
+1 for removing them as well, all the mentioned sw versions in [5,6]
are extremely, extremely old.
Best regards,
Alessandro
On Wed, 2 Jun 2021 at 14:38, Michael Mior <mm...@apache.org> wrote:
>
> +1 for removing these entirely. I don't believe they are currently necessary.
> --
> Michael Mior
> mmior@apache.org
>
> Le mer. 2 juin 2021 à 06:13, Stamatis Zampetakis <za...@gmail.com> a écrit :
> >
> > Hi all,
> >
> > In the recent votes for Calcite [1] and Avatica [2] there were some -1
> > votes regarding minified javascript files present in the source releases.
> >
> > The concerns are raised for the following files:
> > site/js/html5shiv.min.js
> > site/js/respond.min.js
> >
> > From discussions in other lists it seems that there are Apache source
> > releases including minified files so I don't think we are violating any
> > policy by including them but there are deferring opinions on this topic
> > [3,4].
> >
> > To avoid bringing back the discussion to if minified javascript should be
> > present or not I would like to propose one of the following alternatives:
> >
> > 1. It seems that both of the aforementioned scripts [5,6] are used for
> > compatibility reasons with old browsers. I think most of the people are not
> > using these browsers anymore so I would suggest removing them altogether
> > from the code.
> >
> > 2. If for some reason we need to keep them then we could directly use the
> > non minified version. The difference of minified vs unminified for both
> > files is ~6KB so I doubt it will have any real impact with the internet
> > connections that we use nowadays.
> >
> > What do you think?
> >
> > Best,
> > Stamatis
> >
> > [1]
> > https://lists.apache.org/thread.html/r049cf5b953eb5824ba37df21094dd7c1e92146d659db4735ad121593%40%3Cdev.calcite.apache.org%3E
> > [2]
> > https://lists.apache.org/thread.html/r074720fc062bde09a7e69dc77f77754c7fd4c22f1357514f6b2196d0%40%3Cdev.calcite.apache.org%3E
> > [3]
> > https://lists.apache.org/thread.html/rcddc30dd1f0c7f20709e09de7202d4d6885d6235a7fce1c1ab46e4ed%40%3Clegal-discuss.apache.org%3E
> > [4]
> > http://mail-archives.apache.org/mod_mbox/incubator-general/201805.mbox/%3c89A47C0B-E74E-4571-B282-DBE505291539@classsoftware.com%3e
> > [5] https://github.com/scottjehl/Respond
> > [6] https://github.com/aFarkas/html5shiv
Re: Minified javascript in source releases
Posted by Michael Mior <mm...@apache.org>.
+1 for removing these entirely. I don't believe they are currently necessary.
--
Michael Mior
mmior@apache.org
Le mer. 2 juin 2021 à 06:13, Stamatis Zampetakis <za...@gmail.com> a écrit :
>
> Hi all,
>
> In the recent votes for Calcite [1] and Avatica [2] there were some -1
> votes regarding minified javascript files present in the source releases.
>
> The concerns are raised for the following files:
> site/js/html5shiv.min.js
> site/js/respond.min.js
>
> From discussions in other lists it seems that there are Apache source
> releases including minified files so I don't think we are violating any
> policy by including them but there are deferring opinions on this topic
> [3,4].
>
> To avoid bringing back the discussion to if minified javascript should be
> present or not I would like to propose one of the following alternatives:
>
> 1. It seems that both of the aforementioned scripts [5,6] are used for
> compatibility reasons with old browsers. I think most of the people are not
> using these browsers anymore so I would suggest removing them altogether
> from the code.
>
> 2. If for some reason we need to keep them then we could directly use the
> non minified version. The difference of minified vs unminified for both
> files is ~6KB so I doubt it will have any real impact with the internet
> connections that we use nowadays.
>
> What do you think?
>
> Best,
> Stamatis
>
> [1]
> https://lists.apache.org/thread.html/r049cf5b953eb5824ba37df21094dd7c1e92146d659db4735ad121593%40%3Cdev.calcite.apache.org%3E
> [2]
> https://lists.apache.org/thread.html/r074720fc062bde09a7e69dc77f77754c7fd4c22f1357514f6b2196d0%40%3Cdev.calcite.apache.org%3E
> [3]
> https://lists.apache.org/thread.html/rcddc30dd1f0c7f20709e09de7202d4d6885d6235a7fce1c1ab46e4ed%40%3Clegal-discuss.apache.org%3E
> [4]
> http://mail-archives.apache.org/mod_mbox/incubator-general/201805.mbox/%3c89A47C0B-E74E-4571-B282-DBE505291539@classsoftware.com%3e
> [5] https://github.com/scottjehl/Respond
> [6] https://github.com/aFarkas/html5shiv