You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Steve Stock <st...@technolope.org> on 2001/06/20 19:55:18 UTC
current BaseValueParser doesn't compile (patch included)
A recent update to org.apache.turbine.util.parser.BaseValueParser causes
it to not compile. As of right now it's still broken in CVS It's just
a simple oops. This patch should make it behave as was intended:
diff -u -w -r1.12 BaseValueParser.java
--- org/apache/turbine/util/parser/BaseValueParser.java 2001/06/20 09:54:03 1.12
+++ org/apache/turbine/util/parser/BaseValueParser.java 2001/06/20 17:47:11
@@ -1161,7 +1161,7 @@
{
value = ((String[])object)[0];
}
- return (value == null ? null : StringUtils.isValid(value));
+ return (StringUtils.isValid(value) ? new NumberKey(value) : null);
}
catch ( ClassCastException e )
{
Steve Stock
steve@technolope.org
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org
Re: current BaseValueParser doesn't compile (patch included)
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Thanks Steve, that was my bad (though I did verify compilation, dunno
how that was missed). Patch applied.
Daniel Rall
steve@technolope.org (Steve Stock) writes:
> A recent update to org.apache.turbine.util.parser.BaseValueParser causes
> it to not compile. As of right now it's still broken in CVS It's just
> a simple oops. This patch should make it behave as was intended:
>
> diff -u -w -r1.12 BaseValueParser.java
> --- org/apache/turbine/util/parser/BaseValueParser.java 2001/06/20 09:54:03 1.12
> +++ org/apache/turbine/util/parser/BaseValueParser.java 2001/06/20 17:47:11
> @@ -1161,7 +1161,7 @@
> {
> value = ((String[])object)[0];
> }
> - return (value == null ? null : StringUtils.isValid(value));
> + return (StringUtils.isValid(value) ? new NumberKey(value) : null);
> }
> catch ( ClassCastException e )
> {
---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org