[GitHub] [jena] seaninryan commented on a change in pull request #534: [WIP] Proof of concept for prometheus endpoint

[GitBox <gi...@apache.org>]

seaninryan commented on a change in pull request #534: [WIP] Proof of concept for prometheus endpoint
URL: https://github.com/apache/jena/pull/534#discussion_r272536407
 
 

 ##########
 File path: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/metrics/SimpleMetricsProvider.java
 ##########
 @@ -33,7 +34,8 @@ public MeterRegistry getMeterRegistry() {
 
     @Override
     public void scrape(HttpAction action) {
-        ServletOps.errorNotImplemented( "SimpleMeterRegistry isn't scrapeable" );
+        ServletOps.responseSendError(action.response, HttpSC.NOT_IMPLEMENTED_501,
+                "SimpleMeterRegistry isn't scrapeable" );
 
 Review comment:
   Yeah that works great - I've just pushed the change.
   
   The previous implementation was left over from when I was doing that `/$/extras/*` stuff that's gone now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services