You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Brian Bockelman (JIRA)" <ji...@apache.org> on 2008/10/08 02:04:44 UTC
[jira] Created: (HADOOP-4369) Metric Averages are not averages
Metric Averages are not averages
--------------------------------
Key: HADOOP-4369
URL: https://issues.apache.org/jira/browse/HADOOP-4369
Project: Hadoop Core
Issue Type: Bug
Components: metrics
Affects Versions: 0.18.1
Reporter: Brian Bockelman
Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4369:
-------------------------------------------
Status: Patch Available (was: Open)
re-submitting ...
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4369:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4369) Metric Averages are not averages
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642308#action_12642308 ]
Hudson commented on HADOOP-4369:
--------------------------------
Integrated in Hadoop-trunk #640 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/640/])
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-4369:
----------------------------------
Fix Version/s: (was: 0.18.1)
0.18.2
0.18.1 has already been released.
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-4369:
--------------------------------
Status: Patch Available (was: Open)
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Bockelman updated HADOOP-4369:
------------------------------------
Fix Version/s: 0.18.1
Status: Patch Available (was: Open)
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Fix For: 0.18.1
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4369) Metric Averages are not averages
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641180#action_12641180 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-4369:
------------------------------------------------
{noformat}
[exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}
The change is simple. We don't need a new test here.
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4369:
------------------------------------
Priority: Blocker (was: Major)
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4369:
-------------------------------------------
Resolution: Fixed
Assignee: Brian Bockelman
Status: Resolved (was: Patch Available)
It passed all tests in my local machine.
I just committed this. Thanks, Brian.
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Assignee: Brian Bockelman
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4369:
------------------------------------
Status: Open (was: Patch Available)
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-4369:
-------------------------------------------
Status: Open (was: Patch Available)
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Priority: Blocker
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-4369:
--------------------------------
Status: Open (was: Patch Available)
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Brian Bockelman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Bockelman updated HADOOP-4369:
------------------------------------
Attachment: hadoop-4369.patch
Patch to make averages actually averages in the Hadoops metric package.
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Fix For: 0.18.1
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-4369) Metric Averages are not averages
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-4369:
------------------------------------
Status: Patch Available (was: Open)
See if Hudson will do the test.
In any case, Nicholas will review the change.
Promote for 19.
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-4369) Metric Averages are not averages
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640963#action_12640963 ]
Johan Oskarsson commented on HADOOP-4369:
-----------------------------------------
For some reason this hasn't been run through hudson, could you resubmit the patch Brian?
> Metric Averages are not averages
> --------------------------------
>
> Key: HADOOP-4369
> URL: https://issues.apache.org/jira/browse/HADOOP-4369
> Project: Hadoop Core
> Issue Type: Bug
> Components: metrics
> Affects Versions: 0.18.1
> Reporter: Brian Bockelman
> Fix For: 0.18.2
>
> Attachments: hadoop-4369.patch
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Metrics averages are not averages; instead of updating the metric with the average number periodically, Hadoop metrics *increments* the metric.
> I.e., each update we have value = old_value + current average. Instead, we want each update to have value = current_average.
> Patch will be attached momentarily.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.