[GitHub] [doris] xinyiZzz commented on a diff in pull request #16987: [improvement](memory) Support GC segment cache, when memory insufficient

["xinyiZzz (via GitHub)" <gi...@apache.org>]

xinyiZzz commented on code in PR #16987:
URL: https://github.com/apache/doris/pull/16987#discussion_r1113738207


##########
be/src/util/mem_info.cpp:
##########
@@ -97,6 +98,8 @@ void MemInfo::process_cache_gc(int64_t& freed_mem) {
     freed_mem +=
             StoragePageCache::instance()->get_page_cache_mem_consumption(segment_v2::DATA_PAGE);
     StoragePageCache::instance()->prune(segment_v2::DATA_PAGE);
+    freed_mem += SegmentLoader::instance()->segment_cache_mem_consumption();
+    SegmentLoader::instance()->prune_all();

Review Comment:
   fixed,
   minor gc only prune outdated segment cache
   full gc prune all



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org