You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/09/19 00:28:07 UTC

[GitHub] [spark] itholic commented on a diff in pull request #40642: [SPARK-43010][PYTHON] Migrate Column errors into error class

itholic commented on code in PR #40642:
URL: https://github.com/apache/spark/pull/40642#discussion_r1329417329


##########
python/pyspark/errors/error_classes.py:
##########
@@ -24,6 +24,21 @@
       "Argument `<arg_name>` is required when <condition>."
     ]
   },
+  "CANNOT_ACCESS_TO_DUNDER": {

Review Comment:
   We can update it as a follow-up if there is any better suggestions for the name of error classes (It's not a API changes but only affect to error message, so it would be fine)
   
   Which one do you prefer `CANNOT_ACCESS_DUNDER` or `ILLEGAL_ACCESS_TO_DUNDER`? Can you pick one of them, or even better idea? Then I can make a follow-up for you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org