[GitHub] [calcite] hsyuan commented on a change in pull request #1547: [CALCITE-3460] Poor performance in RexReplacer for large queries

[GitBox <gi...@apache.org>]

hsyuan commented on a change in pull request #1547: [CALCITE-3460] Poor performance in RexReplacer for large queries
URL: https://github.com/apache/calcite/pull/1547#discussion_r340788663
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rex/RexShuttle.java
 ##########
 @@ -160,8 +161,8 @@ public RexNode visitCall(final RexCall call) {
    */
   public void visitList(
       List<? extends RexNode> exprs, List<RexNode> outExprs) {
-    for (RexNode expr : exprs) {
-      outExprs.add(expr.accept(this));
+    for (int i = 0; i < exprs.size(); i++) {
+      outExprs.add(exprs.get(i).accept(this));
 
 Review comment:
   There is nothing wrong with ImmutableList. It is just not a good fit here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services