[GitHub] [incubator-devlake] keon94 commented on pull request #3761: Don't check network connection when service is behind a proxy

[GitBox <gi...@apache.org>]

keon94 commented on PR #3761:
URL: https://github.com/apache/incubator-devlake/pull/3761#issuecomment-1322468828

   > > But why not CheckNetwork by proxy?
   > 
   > Well currently the network check is just trying to set up a connection to the server, which isn't possible because it's behind an http proxy. To test by proxy the helper object would need to do an http request. Not sure if that can be done in a generic enough way to support any http api (if ApiClient is supposed to be a generic helper). Maybe it's better to let the different plugins check connectivity to the service?
   
   Looking at [this post](https://stackoverflow.com/questions/14661511/setting-up-proxy-for-http-client), looks like there is a generic way to handle proxy calls (via the http.DefaultTransport modification). Perhaps we can leverage that? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org