[jira] [Commented] (CLIMATE-561) easy-ocw/install-osx.sh script should not assume relative locations for dependency utilitiy files

["Michael Joyce (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLIMATE-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274291#comment-14274291 ] 

Michael Joyce commented on CLIMATE-561:
---------------------------------------

One lazy way of handling it is to simply add some flags for setting the location of these values explicitly. If those flags aren't set then we just default to what we assume now. We should also be able to simply use the ocw_path that we request from the user. However, I just noticed that we don't actually request this from them in the OS X script but we do in the Ubuntu script. Perhaps this brings up a bigger problem. Maybe we should split the installation up differently. At the moment we're splitting based on operating system (install-osx and install-ubuntu). Maybe it would be a good idea to split the individual functionality out into scripts that handle each subtask and call from a generic install script (install.sh calls some generic install-virtual-env which does different stuff depending on OS, etc.).

Thoughts? Might make some of this stuff a bit easier in the future so we don't have to duplicate all this boilerplate across all supported OS scripts.

> easy-ocw/install-osx.sh script should not assume relative locations for dependency utilitiy files
> -------------------------------------------------------------------------------------------------
>
>                 Key: CLIMATE-561
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-561
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: easy-ocw
>    Affects Versions: 0.4, 0.5
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>             Fix For: 1.0.0
>
>
> Right now there are a number of flat files contained within ./easy-ocw/ which are utilized (very cunningly) to make the easy install process smooth.
> An improvement to the install scripts themselves would be to NOT assume these files are relative to where the script was invoked.
> We should be able to find these files based on a $OCW_HOME or something. Right now (as we are already setting virtualenv etc) I am not entirely sure how we do this cleanly.
> Lets talk about it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)