You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/26 04:02:08 UTC

[GitHub] Soonhwan-Kwon opened a new pull request #9569: fix CreateOp of altering shape operations to accept dtypes of uint8 and int32

Soonhwan-Kwon opened a new pull request #9569: fix CreateOp of altering shape operations to accept dtypes of uint8 and int32
URL: https://github.com/apache/incubator-mxnet/pull/9569
 
 
   ## Description ##
   Same context as https://github.com/apache/incubator-mxnet/pull/9561,
   to deal with quantization in future,
   operators(sequence_last, sequence_mask, sequence_revert,swapaxis) should have capability to accept uint8 and int32.
   Like slice_channel, it can be achieved by changing MSHADOW_REAL_TYPE_SWITCH to MSHADOW_TYPE_SWITCH as concat(https://github.com/apache/incubator-mxnet/blob/d2a856a3a2abb4e72edc301b8b821f0b75f30722/src/operator/concat.cu)
   I tested them and it worked well both cpu,gpu setting,
   
   And there was wrong argument y appeared in document of sequence_maks instead of right argument sequence_length, so I fixed it also. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services