You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/04/27 06:20:42 UTC

Review Request 72435: Set OOM score adj when Docker container's memory limit is infinite.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72435/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10053
    https://issues.apache.org/jira/browse/MESOS-10053


Repository: mesos


Description
-------

Set OOM score adj when Docker container's memory limit is infinite.


Diffs
-----

  src/docker/docker.cpp a5f15dda81d459f05fc16c29d58d81bf8183e9cf 


Diff: https://reviews.apache.org/r/72435/diff/1/


Testing
-------


Thanks,

Qian Zhang


Re: Review Request 72435: Set OOM score adj when Docker container's memory limit is infinite.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72435/#review220496
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72435]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh

- Mesos Reviewbot


On April 27, 2020, 6:20 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72435/
> -----------------------------------------------------------
> 
> (Updated April 27, 2020, 6:20 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
>     https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set OOM score adj when Docker container's memory limit is infinite.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp a5f15dda81d459f05fc16c29d58d81bf8183e9cf 
> 
> 
> Diff: https://reviews.apache.org/r/72435/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 72435: Set OOM score adj when Docker container's memory limit is infinite.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72435/#review220502
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On April 27, 2020, 6:20 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72435/
> -----------------------------------------------------------
> 
> (Updated April 27, 2020, 6:20 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
>     https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set OOM score adj when Docker container's memory limit is infinite.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp a5f15dda81d459f05fc16c29d58d81bf8183e9cf 
> 
> 
> Diff: https://reviews.apache.org/r/72435/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>