You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Gus Heck (Jira)" <ji...@apache.org> on 2024/10/09 14:04:00 UTC

[jira] [Created] (SOLR-17486) Potentially unused code in SolrDispatchFilter - abortErrorMessage

Gus Heck created SOLR-17486:
-------------------------------

             Summary: Potentially unused code in SolrDispatchFilter - abortErrorMessage
                 Key: SOLR-17486
                 URL: https://issues.apache.org/jira/browse/SOLR-17486
             Project: Solr
          Issue Type: Bug
      Security Level: Public (Default Security Level. Issues are Public)
    Affects Versions: main (10.0)
            Reporter: Gus Heck
         Attachments: image-2024-10-09-10-01-33-503.png

I was reading code on main, and noticed that SolrDispatchFilter has a string field called abortErrorMessage. This is checked in HttpSolrCall, and the code purports to exit if there is an abort message, but I see no place in code where this is ever set.

It is protected access so maybe there's some intent to set it in an overridden version of SolrDispatchFilter somewhere, that has become obsolete? This code looks like it can be deleted. Raising this issue to find out if anyone has a notion of why it should be retained.

!image-2024-10-09-10-01-33-503.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org