You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/26 14:59:05 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new issue, #677: Exclude unstable branch while canceling previous workflows
PragmaTwice opened a new issue, #677:
URL: https://github.com/apache/incubator-kvrocks/issues/677
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Motivation

As shown in the figure above, the retrying workflow was canceled due to a new commit.
We may retry the kvrocks ci action of some commits in the unstable branch.
At this time, if the unstable branch can only run one workflow at the same time, it will cause some trouble.
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #677: Exclude unstable branch while canceling previous workflows
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #677:
URL: https://github.com/apache/incubator-kvrocks/issues/677#issuecomment-1166574956
> I don't think this is a big deal. Always we focus on the latest version and it's fine if only the nightly version passes CI.
>
> If you want to debugging an unstable test, you may open a branch on fork or send a draft pull request.
In fact, there is another situation.
For example, if two commits are merged into the unstable branch within a short time interval, the workflow of the previous commit will be canceled, and the actions status of the previous commit will display a ❌.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on issue #677: Exclude unstable branch while canceling previous workflows
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #677:
URL: https://github.com/apache/incubator-kvrocks/issues/677#issuecomment-1166581614
@PragmaTwice since we require every PR should be up-to-date before merge, actually we can skip running CI in `unstable` branch.
See also [Apache Pulsar's CI settings](https://github.com/apache/pulsar/blob/6c715e08c67c40221c8c08cbe0b31d3a6aa1bf32/.github/workflows/pulsar-ci.yaml):
```yaml
on:
pull_request:
branches:
- master
push:
branches:
- branch-*
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun closed issue #677: Exclude unstable branch while canceling previous workflows
Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #677: Exclude unstable branch while canceling previous workflows
URL: https://github.com/apache/incubator-kvrocks/issues/677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on issue #677: Exclude unstable branch while canceling previous workflows
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #677:
URL: https://github.com/apache/incubator-kvrocks/issues/677#issuecomment-1166678902
@PragmaTwice it sounds like something similar to "MergeCI" in TiDB project. However, I'd prefer running tests as early as possible instead of running less tests and fix bugs later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on issue #677: Exclude unstable branch while canceling previous workflows
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #677:
URL: https://github.com/apache/incubator-kvrocks/issues/677#issuecomment-1166571732
I don't think this is a big deal. Always we focus on the latest version and it's fine if only the nightly version passes CI.
If you want to debugging an unstable test, you may open a branch on fork or send a draft pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #677: Exclude unstable branch while canceling previous workflows
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #677:
URL: https://github.com/apache/incubator-kvrocks/issues/677#issuecomment-1166584509
> @PragmaTwice since we require every PR should be up-to-date before merge, actually we can skip running CI in `unstable` branch.
>
> See also [Apache Pulsar's CI settings](https://github.com/apache/pulsar/blob/6c715e08c67c40221c8c08cbe0b31d3a6aa1bf32/.github/workflows/pulsar-ci.yaml):
>
> ```yaml
> on:
> pull_request:
> branches:
> - master
> push:
> branches:
> - branch-*
> ```
It is a good idea, actually I think maybe we can use another workflow on unstable branch to build and test kvrocks with more environment and build options than the current workflow trigger by PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org