You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Soren Hilmer <so...@tietoenator.com> on 2005/09/07 09:11:30 UTC
Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
You move fast Stefano! I was about to commit my fix for it, when I ran into
the SpoolManager issues.
I will compare our fixes :-)
--Søren
On Wednesday 07 September 2005 00:34, Stefano Bagnara (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/JAMES-413?page=all ]
>
> Stefano Bagnara resolved JAMES-413:
> -----------------------------------
>
> Resolution: Fixed
>
> I was working on DNSServer so I fixed this: Soren, please review the patch.
>
> > James does not resolve CNAME DNS registrations
> > ----------------------------------------------
> >
> > Key: JAMES-413
> > URL: http://issues.apache.org/jira/browse/JAMES-413
> > Project: James
> > Type: Bug
> > Components: DNSServer
> > Versions: 2.2.0
> > Reporter: Soren Hilmer
> > Assignee: Stefano Bagnara
> > Fix For: 2.3.0
> > Attachments: DNSServerTest.java
> >
> > James does not resolve CNAME DNS entries as required by RFC-2821 sections
> > 3.6 and 5
--
Søren Hilmer, M.Sc.
R&D manager Phone: +45 72 30 64 00
TietoEnator IT+ A/S Fax: +45 72 30 64 02
Ved Lunden 12 Direct: +45 72 30 64 57
DK-8230 Åbyhøj Email: soren.hilmer <at> tietoenator.com
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
Posted by Stefano Bagnara <ap...@bago.org>.
Noel,
thank you for noticing this.
I added a testcase and fixed it.
Should we add another try/catch level for the second mx so that an
exception to the second lookup would result in the A record? (otherwise
null)
Stefano
Noel J. Bergman wrote:
> I was just looking over the fix ...
>
> Shouldn't the return of the CNAME's MX records follow the pattern, and be:
>
> return Collections.unmodifiableCollection(cnameMXrecords);
>
> Have we discussed this before? The try { return } finally { return } code
> there is an ugly pattern, and I seem to recall us discussing that pattern
> previously.
>
> --- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
RE: Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
Posted by "Noel J. Bergman" <no...@devtech.com>.
I was just looking over the fix ...
Shouldn't the return of the CNAME's MX records follow the pattern, and be:
return Collections.unmodifiableCollection(cnameMXrecords);
Have we discussed this before? The try { return } finally { return } code
there is an ugly pattern, and I seem to recall us discussing that pattern
previously.
--- Noel
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
Posted by Soren Hilmer <so...@tietoenator.com>.
FYI, I compared our codes and while functionally equivalent, I must admit that
your fix was cleaner and simpler ;-(
So let us stick to that.
--Søren
On Wednesday 07 September 2005 09:25, Stefano Bagnara wrote:
> > You move fast Stefano! I was about to commit my fix for it,
> > when I ran into the SpoolManager issues.
> > I will compare our fixes :-)
>
> Feel free to overwrite my changes with yours! Mine has been a really fast
> fix.
> I will run my test against your code, eventually!
>
> Stefano
>
> PS: sorry, I've seen you have the bug assigned but I was not sure you were
> working on it so I gave it a try.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
--
Søren Hilmer, M.Sc.
R&D manager Phone: +45 72 30 64 00
TietoEnator IT+ A/S Fax: +45 72 30 64 02
Ved Lunden 12 Direct: +45 72 30 64 57
DK-8230 Åbyhøj Email: soren.hilmer <at> tietoenator.com
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
Re: Resolved: (JAMES-413) James does not resolve CNAME DNS registrations
Posted by Stefano Bagnara <ap...@bago.org>.
> You move fast Stefano! I was about to commit my fix for it,
> when I ran into the SpoolManager issues.
> I will compare our fixes :-)
Feel free to overwrite my changes with yours! Mine has been a really fast
fix.
I will run my test against your code, eventually!
Stefano
PS: sorry, I've seen you have the bug assigned but I was not sure you were
working on it so I gave it a try.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org