Re: Review Request 73469: RANGER-3314: Importing atlas policy with old schema displays incorrect permissions on UI

[Kishor Gollapalliwar <ki...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73469/#review223585
-----------------------------------------------------------


Ship it!




Ship It!

- Kishor Gollapalliwar


On July 29, 2021, 1:03 p.m., Mahesh Bandal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73469/
> -----------------------------------------------------------
> 
> (Updated July 29, 2021, 1:03 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3314
>     https://issues.apache.org/jira/browse/RANGER-3314
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This is with respect to RANGER-3195 where we have moved the Add/Update/Remove classification permissions to a new classification resource.
> 
> When old atlas policy json is imported, it adds permissions like "entity-add-classification", "entity-update-classification", "entity-remove-classification" in the permission list where the resource is “entity”. These permissions are not valid for resourceType=entity
> 
> Ranger should validate accessTypeRestrictions for each resource during policyImport.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java 0ba1fb918 
> 
> 
> Diff: https://reviews.apache.org/r/73469/diff/1/
> 
> 
> Testing
> -------
> 
> Performed policy import for all service types.
> 
> 
> Thanks,
> 
> Mahesh Bandal
> 
>