You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Gareth Morgan <GM...@Armature.com> on 2000/11/14 12:53:21 UTC

[PATCH] JspRuntimeLibrary boolean bug

This file seems to use the wrong method of String->Boolean conversion,
resuting in an always false result.
- Could someone review and submit this, if oppropriate? I don't have access.

This diff is against jakarta-tomcat-3.2-b7

share\org\apache\jasper\runtime\JspRuntimeLibrary.java

326c326
< 		    tmpval[i] = Boolean.getBoolean (values[i]);
---
> 			tmpval[i] = ( Boolean.valueOf(values[i])
).booleanValue();			


Gareth Morgan

Re: [PATCH] JspRuntimeLibrary boolean bug

Posted by Pierre Delisle <pi...@sun.com>.
Gareth,

Thanks for the patch. I've committed it to 4.0, and will wait for feedback
from Craig to see if it can be committed to 3.2b7.

    -- Pierre

Gareth Morgan wrote:
> 
> This file seems to use the wrong method of String->Boolean conversion,
> resuting in an always false result.
> - Could someone review and submit this, if oppropriate? I don't have access.
> 
> This diff is against jakarta-tomcat-3.2-b7
> 
> share\org\apache\jasper\runtime\JspRuntimeLibrary.java
> 
> 326c326
> <                   tmpval[i] = Boolean.getBoolean (values[i]);
> ---
> >                       tmpval[i] = ( Boolean.valueOf(values[i])
> ).booleanValue();
> 
> Gareth Morgan
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org