You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/03 14:39:43 UTC
[GitHub] [apisix] Yiyiyimu opened a new pull request #3509: fix: markdown-link-check (gh actions) not works for Apache project
Yiyiyimu opened a new pull request #3509:
URL: https://github.com/apache/apisix/pull/3509
Signed-off-by: yiyiyimu <wo...@gmail.com>
### What this PR does / why we need it:
The original markdown-link-check use `gaurav-nelson/github-action-markdown-link-check` in github actions, which is not allowed for Apache project and [aborted](https://github.com/apache/apisix/actions/runs/534012083) for a while. Replace it with `install node.js` and `npm install markdown-link-check`
Also fix the problem, that there is no need to `spellcheck` for `push`, when `pull_request` already checked that.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3509: fix: markdown-link-check (gh actions) not works for Apache project
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #3509:
URL: https://github.com/apache/apisix/pull/3509#issuecomment-772562236
> Possible duplicate #3197
Good to know that. Thanks for remind!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3509: chore: remove spellcheck for `push`
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3509:
URL: https://github.com/apache/apisix/pull/3509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jbampton commented on pull request #3509: fix: markdown-link-check (gh actions) not works for Apache project
Posted by GitBox <gi...@apache.org>.
jbampton commented on pull request #3509:
URL: https://github.com/apache/apisix/pull/3509#issuecomment-772560818
Possible duplicate #3197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3509: chore: remove spellcheck for `push`
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #3509:
URL: https://github.com/apache/apisix/pull/3509#issuecomment-772635755
#3197 has been merged
can we need to close this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu edited a comment on pull request #3509: chore: remove spellcheck for `push`
Posted by GitBox <gi...@apache.org>.
Yiyiyimu edited a comment on pull request #3509:
URL: https://github.com/apache/apisix/pull/3509#issuecomment-772970846
> close this PR?
No I reverted the part duplicated of #3197, the rest one is new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3509: chore: remove spellcheck for `push`
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #3509:
URL: https://github.com/apache/apisix/pull/3509#issuecomment-772970846
> close this PR?
No I reverted the part duplicated of #3197, the rest one is new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis edited a comment on pull request #3509: chore: remove spellcheck for `push`
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on pull request #3509:
URL: https://github.com/apache/apisix/pull/3509#issuecomment-772635755
#3197 has been merged
close this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3509: chore: remove spellcheck for `push`
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #3509:
URL: https://github.com/apache/apisix/pull/3509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org