You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Greg Stein <gs...@lyra.org> on 2001/02/08 01:30:14 UTC
Re: cvs commit: httpd-2.0 CHANGES Makefile.in
On Wed, Feb 07, 2001 at 07:07:46PM -0000, rbb@apache.org wrote:
> rbb 01/02/07 11:07:46
>
> Modified: . CHANGES Makefile.in
> Log:
> Install all required header files. Without these, some modules can not
> be compiled outside the src tree.
>...
> --- Makefile.in 2001/01/28 20:06:18 1.55
> +++ Makefile.in 2001/02/07 19:07:46 1.56
> @@ -105,12 +105,14 @@
> @if test -f $(srcdir)/os/$(OS_DIR)/os-inline.c; then \
> cp -p $(srcdir)/os/$(OS_DIR)/os-inline.c $(includedir); \
> fi;
> + @cp -p $(srcdir)/server/mpm/$(MPM_NAME)/*.h $(includedir)
> @cp -p $(srcdir)/modules/dav/main/mod_dav.h $(includedir)
> @cp -p $(srcdir)/modules/filters/mod_include.h $(includedir)
> @cp -p $(srcdir)/srclib/expat-lite/*.h $(includedir)
> @cp -p $(srcdir)/srclib/pcre/*.h $(includedir)
> @cp -p $(srcdir)/srclib/apr/include/*.h $(includedir)
> @cp -p $(srcdir)/srclib/apr-util/include/*.h $(includedir)
> + @cp -p $(srcdir)/os/$(OS_DIR)/*.h $(includedir)
> @chmod 644 $(includedir)/*.h
Woah!
Who is using MPM headers? Or the OS headers? Aren't all of those supposed to
be private? e.g. for the MPM, we have a generic, common header that can be
used as an API.
And what in the OS directory needs to be exported?
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: httpd-2.0 CHANGES Makefile.in
Posted by rb...@covalent.net.
> > +++ Makefile.in 2001/02/07 19:07:46 1.56
> > @@ -105,12 +105,14 @@
> > @if test -f $(srcdir)/os/$(OS_DIR)/os-inline.c; then \
> > cp -p $(srcdir)/os/$(OS_DIR)/os-inline.c $(includedir); \
> > fi;
> > + @cp -p $(srcdir)/server/mpm/$(MPM_NAME)/*.h $(includedir)
> > @cp -p $(srcdir)/modules/dav/main/mod_dav.h $(includedir)
> > @cp -p $(srcdir)/modules/filters/mod_include.h $(includedir)
> > @cp -p $(srcdir)/srclib/expat-lite/*.h $(includedir)
> > @cp -p $(srcdir)/srclib/pcre/*.h $(includedir)
> > @cp -p $(srcdir)/srclib/apr/include/*.h $(includedir)
> > @cp -p $(srcdir)/srclib/apr-util/include/*.h $(includedir)
> > + @cp -p $(srcdir)/os/$(OS_DIR)/*.h $(includedir)
> > @chmod 644 $(includedir)/*.h
>
> Woah!
>
> Who is using MPM headers? Or the OS headers? Aren't all of those supposed to
> be private? e.g. for the MPM, we have a generic, common header that can be
> used as an API.
>
> And what in the OS directory needs to be exported?
Anytime a file includes the scoreboard, they also need the MPM
definitions, because otherwise they can't find the size of the scoreboard.
The OS headers are used for ap_os_create_priviledged_process, which are
useful for anybody creating a CGI script. These headers have information
useful to modules, because they declare either information that defines
how the server is built, or they define functions used by modules. Just
because a header is in the OS directory, or the MPM directory doesn't mean
it's private, it means that the information changes based on OS or MPM.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------