You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/22 18:58:20 UTC

[GitHub] [beam] udim commented on a change in pull request #9907: [BEAM-4091] Pass type hints in ptransform_fn

udim commented on a change in pull request #9907:
URL: https://github.com/apache/beam/pull/9907#discussion_r492965241



##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -476,6 +499,26 @@ def _add_argparse_args(cls, parser):
         'time. NOTE: only supported with portable runners '
         '(including the DirectRunner)')
 
+  def validate(self, unused_validator):
+    errors = []
+    if beam.version.__version__ >= '3':

Review comment:
       This error is like a long-term TODO so that we don't forget to update defaults in v3.
   It could mean that we enable everything and retire this flag. It depends on how stable type hints are.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org