You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by di...@apache.org on 2019/10/14 01:43:43 UTC
[rocketmq-client-go] branch native updated: fix: avoid extra err
info on pushConsumer startup - register consumer before defaultConsumer
start] Closes #194
This is an automated email from the ASF dual-hosted git repository.
dinglei pushed a commit to branch native
in repository https://gitbox.apache.org/repos/asf/rocketmq-client-go.git
The following commit(s) were added to refs/heads/native by this push:
new 398e37c fix: avoid extra err info on pushConsumer startup - register consumer before defaultConsumer start] Closes #194
398e37c is described below
commit 398e37c244b5dadd0a25a6c5888f5e807e33999a
Author: xujianhai666 <ze...@bytedance.com>
AuthorDate: Sun Oct 13 16:35:23 2019 +0800
fix: avoid extra err info on pushConsumer startup
- register consumer before defaultConsumer start]
Closes #194
---
consumer/push_consumer.go | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/consumer/push_consumer.go b/consumer/push_consumer.go
index f8375fc..8f72805 100644
--- a/consumer/push_consumer.go
+++ b/consumer/push_consumer.go
@@ -114,11 +114,6 @@ func (pc *pushConsumer) Start() error {
pc.state = internal.StateStartFailed
pc.validate()
- err = pc.defaultConsumer.start()
- if err != nil {
- return
- }
-
err := pc.client.RegisterConsumer(pc.consumerGroup, pc)
if err != nil {
pc.state = internal.StateStartFailed
@@ -126,6 +121,11 @@ func (pc *pushConsumer) Start() error {
err = ErrCreated
}
+ err = pc.defaultConsumer.start()
+ if err != nil {
+ return
+ }
+
go func() {
// initial lock.
time.Sleep(1000 * time.Millisecond)