You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/05 01:38:19 UTC
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #26594:
[SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit
jdk8/jdk11
AngersZhuuuu commented on a change in pull request #26594: [SPARK-29957][TEST][test-java11] Reset MiniKDC's default enctypes to fit jdk8/jdk11
URL: https://github.com/apache/spark/pull/26594#discussion_r354073203
##########
File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
##########
@@ -136,9 +137,49 @@ class KafkaTestUtils(
kdcConf.setProperty(MiniKdc.DEBUG, "true")
kdc = new MiniKdc(kdcConf, kdcDir)
kdc.start()
+ // TODO https://issues.apache.org/jira/browse/SPARK-30037
+ // Need to customize krb5.conf like Kafka
Review comment:
> nit. `// Need` -> `// Need`. (reducing one space between `//` and `Need`.).
Yah, updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org