You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/06/09 11:32:12 UTC
[GitHub] [commons-crypto] wenwj0 opened a new pull request, #161: CRYPTO-161 Add SM4 encryption support
wenwj0 opened a new pull request, #161:
URL: https://github.com/apache/commons-crypto/pull/161
add sm4-ctr and sm4-cbc in opensslCipher
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] jochenw commented on pull request #161: CRYPTO-161 Add SM4 encryption support
Posted by GitBox <gi...@apache.org>.
jochenw commented on PR #161:
URL: https://github.com/apache/commons-crypto/pull/161#issuecomment-1151042690
Hi,
I am interested in the work, that you are doing here. Question: I notice, that your patch provides changes in the native code. That makes me hesitant: Before I accept the PR, could you help me to setup a build environment, where I can test these changes.
Background: We are considering a new release. As of now, there are no changes in the native code, so we could (in theory) just copy the native files from the previous release. But, for a release, that includes this PR, we would need a running build environment, where we can produce the updated files.
If this is interesting to you, please contact me privately at jochen@apache.org.
Thanks,
Jochen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] garydgregory commented on pull request #161: CRYPTO-161 Add SM4 encryption support
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #161:
URL: https://github.com/apache/commons-crypto/pull/161#issuecomment-1151417971
We need to be able to tell GitHub builds that we need OpenSSL >= 1.1.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] garydgregory commented on pull request #161: CRYPTO-161 Add SM4 encryption support
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #161:
URL: https://github.com/apache/commons-crypto/pull/161#issuecomment-1151182150
We really need to update our GitHub build to deal with the C sources...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] garydgregory commented on pull request #161: CRYPTO-161 Add SM4 encryption support
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #161:
URL: https://github.com/apache/commons-crypto/pull/161#issuecomment-1151181625
https://issues.apache.org/jira/browse/CRYPTO-161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-crypto] wenwj0 commented on pull request #161: CRYPTO-161 Add SM4 encryption support
Posted by GitBox <gi...@apache.org>.
wenwj0 commented on PR #161:
URL: https://github.com/apache/commons-crypto/pull/161#issuecomment-1151845431
I found a warning in [Java CI / build (macos-latest, 8, false)](https://github.com/apache/commons-crypto/runs/6812108742?check_suite_focus=true): `** WARN: Could not enable JNA; detected lib VERSION 0x10000000: Error looking up function 'ENGINE_load_rdrand': dlsym(0x7ff81e7bd070, ENGINE_load_rdrand): symbol not found`
Maybe the OpenSSL in Github builds is 1.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CRYPTO-161 Add SM4 encryption support [commons-crypto]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #161:
URL: https://github.com/apache/commons-crypto/pull/161#issuecomment-1810747230
## Welcome to [Codecov](https://codecov.io?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org