[GitHub] graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard

[GitBox <gi...@apache.org>]

graceguo-supercat commented on issue #4791: apply new Dashboard builder to dashboard
URL: https://github.com/apache/incubator-superset/pull/4791#issuecomment-380604576
 
 
   thanks for your comment. here is my thoughts:
   
   1. I don't like the idea of delete v1, it will destroy code history and make huge duplicates, huge merge conflicts, and very hard to track the changing or fixing of existed features. 
   
   Dashboard v2 is a new project, but most of v2's functionalities are same as v1, like filters, chart render, refresh and immune etc. New Dashboard will improve the layout and organization of Dashboard, which account for a portion of whole Dashboard functionality. Adding new feature, and adding new blocks to existed work is what wee need. 
   
   2. Naming: 
   `charts` are dynamic queries. Each of chart is basically a query based on saved params + dashboard added filter. It's attributes are mostly are dynamic, like request params, response data, start time, last updated time etc.
   
   `allSlices` mapped to `slices` table in backend. It has static data for saved queries (after save query as slice), like name, owner, datasource name, timestamp, param list, etc. These data are new to dashboard, to help user review, filter, sort all existed slices, then add new slices into dashboard. Different than chart data is fetched one by one, available slices should fetch once and fetch all slices data together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services