You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/12/10 18:37:30 UTC
Review Request 41212: Adjust timeout value in
HealthCheckTest.CheckCommandTimeout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41212/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Timothy Chen.
Bugs: MESOS-4024
https://issues.apache.org/jira/browse/MESOS-4024
Repository: mesos
Description
-------
Adjust timeout value in HealthCheckTest.CheckCommandTimeout.
Diffs
-----
src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
Diff: https://reviews.apache.org/r/41212/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 41212: Adjust timeout value in
HealthCheckTest.CheckCommandTimeout.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41212/#review109850
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41212]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 10, 2015, 5:37 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41212/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 5:37 p.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4024
> https://issues.apache.org/jira/browse/MESOS-4024
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adjust timeout value in HealthCheckTest.CheckCommandTimeout.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
>
> Diff: https://reviews.apache.org/r/41212/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41212: Adjust timeout value in
HealthCheckTest.CheckCommandTimeout.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41212/#review110121
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41212]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 12, 2015, 8:11 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41212/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 8:11 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4024
> https://issues.apache.org/jira/browse/MESOS-4024
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adjust timeout value in HealthCheckTest.CheckCommandTimeout.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
>
> Diff: https://reviews.apache.org/r/41212/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41212: Adjust timeout value in
HealthCheckTest.CheckCommandTimeout.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41212/#review110448
-----------------------------------------------------------
This seems identical to my fix here: https://reviews.apache.org/r/40956/
I think mine has more complete changes, can you review mine and use that?
- Timothy Chen
On Dec. 12, 2015, 8:11 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41212/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 8:11 a.m.)
>
>
> Review request for mesos, Ben Mahler and Timothy Chen.
>
>
> Bugs: MESOS-4024
> https://issues.apache.org/jira/browse/MESOS-4024
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adjust timeout value in HealthCheckTest.CheckCommandTimeout.
>
>
> Diffs
> -----
>
> src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
>
> Diff: https://reviews.apache.org/r/41212/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 41212: Adjust timeout value in
HealthCheckTest.CheckCommandTimeout.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41212/
-----------------------------------------------------------
(Updated Dec. 12, 2015, 8:11 a.m.)
Review request for mesos, Ben Mahler and Timothy Chen.
Changes
-------
Make MesosContainerizer log to stdout and stderr.
Bugs: MESOS-4024
https://issues.apache.org/jira/browse/MESOS-4024
Repository: mesos
Description
-------
Adjust timeout value in HealthCheckTest.CheckCommandTimeout.
Diffs (updated)
-----
src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566
Diff: https://reviews.apache.org/r/41212/diff/
Testing
-------
Thanks,
haosdent huang