[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10718: [Optimization] Config module resource relation fix.

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #10718:
URL: https://github.com/apache/dolphinscheduler/pull/10718#discussion_r913337211


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/QueueServiceImpl.java:
##########
@@ -160,7 +160,7 @@ public Map<String, Object> createQueue(User loginUser, String queue, String queu
         queueMapper.insert(queueObj);
         result.put(Constants.DATA_LIST, queueObj);
         putMsg(result, Status.SUCCESS);
-
+        resourcePermissionCheckService.postHandle(AuthorizationType.QUEUE, loginUser.getId(), Collections.singletonList(queueObj.getId()), logger);

Review Comment:
   I have some question:
   
   1. Why to check resource permission of the new created queue here? 
   2. If check fail, should the db transaction rollback?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org