[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

[GitBox <gi...@apache.org>]

fgerlits commented on pull request #791:
URL: https://github.com/apache/nifi-minifi-cpp/pull/791#issuecomment-649667989


   > My tests showed incorrect handling of rotation while the minifi c++ agent is stopped. Instead of finding the file that we were last working with, under a potentially different name, I observed an iteration over all rotated files and consuming everything again. Could you please check that?
   
   https://github.com/apache/nifi-minifi-cpp/pull/791/commits/cca8f3775667e5f824056d681bed3963ad43bcb2 fixes this bug according to my tests -- please redo your tests, too
   
   The rollover detection logic is still primitive: it only checks for rollover if the current file length is less than the last read position.  So if
   * minifi is stopped after reading 100 bytes from test.log
   * 900 more bytes are written to test.log, and it is renamed to test.log.1
   * 300 bytes are written to a new test.log file
   * and minifi is restarted, then it will happily continue from byte 101 in the new file, and skip the 900 + 100 bytes written in between.
   
   I am planning to fix that in a separate pull request, if that is OK.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org