You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Gilles (JIRA)" <ji...@apache.org> on 2019/07/01 07:44:00 UTC

[jira] [Commented] (NUMBERS-125) BigFraction.reduce() and Fraction.getReducedFraction(int, int) are unnecessary

    [ https://issues.apache.org/jira/browse/NUMBERS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875990#comment-16875990 ] 

Gilles commented on NUMBERS-125:
--------------------------------

+1

> BigFraction.reduce() and Fraction.getReducedFraction(int, int) are unnecessary
> ------------------------------------------------------------------------------
>
>                 Key: NUMBERS-125
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-125
>             Project: Commons Numbers
>          Issue Type: Improvement
>          Components: fraction
>    Affects Versions: 1.0
>            Reporter: Heinrich Bohne
>            Priority: Minor
>
> The instance method {{BigFraction.reduce()}} is unnecessary, because the only constructor in this class already reduces the fraction to lowest terms.
> Likewise, the static factory method {{Fraction.getReducedFraction(int, int)}} is unnecessary, because it is functionally completely equivalent to the factory method {{Fraction.of(int, int)}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)